-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
localize
Command Feedback
#4996
Comments
Great feature! <3 I noticed one thing though: it seems to be broken for remote transformers? I don't know if that's a bug or a feature :p I have a repository here reproducing the error I'm seeing: https://github.com/Jell/kustomize-localize-remote-transformers-issue To me this looks like a similar error to: #4958 (not sure if I should open a separate ticket or not, but I saw on the release note I should give feedback on the feature in this issue, so I thought I would start here) |
I think having an --overwrite flag is really needed. We use localize because our git repo is not especially fast. Combined with localize doing everything sequentially, that means pulling resources in our CI pipelines is a no-go as it is too expensive. So we use localize. However, every change requires us to "relocalize" before commits. Which in turns requires us to have a process to remove all our localized folders since we can't just pass a flag --overwrite. |
@Jell Thank you for uploading the exact setup! Yes, this behavior is intentional. However, the feature that the alpha version of We will add this feature in beta if it has enough popularity. |
Don't know if you want this in a separate feature request or not, but I will start here. So I might be misunderstanding how to localize cmd works, but my understanding is that I can download remote resources from remote repositories like github. It would be nice to add the possibility of downloading OCI manifests as well. So a simple example, you can write the following and it will donwload the OCI artifact an unpack it. flux pull artifact oci://ghcr.io/grafana-operator/kustomize/grafana-operator:v5.0.0-rc1 --output ./grafana-operator/ For those of us that uses flux it's nothing strange but for none flux users it would be nice to be able to do the same using Kustomize. So adding oci support to localize to be able to do something like this would be nice: kustomize localize oci://ghcr.io/grafana-operator/kustomize/grafana-operator:v5.0.0-rc1 |
@NissesSenap Thanks for the comment! I agree that we should try to support oci as a remote format - it seems to be becoming a more and more popular way to store kubernetes manifests. If we do support oci, we should support it both with |
@natasha41575 , I didn't know that |
Is there any documentation on how to update custom generators to give them support for localize? For instance ksops. It provides sops secret encryption but its referenced encrypted manifest files are missed. Is there an interface for generators communicating back to localize? In the following example
|
Hi @Striar-Yunis, thank you for the link and exact setup! Unfortunately, in alpha, |
This issue has not been updated in over 1 year, and should be re-triaged. You can:
For more details on the triage process, see https://www.kubernetes.dev/docs/guide/issue-triage/ /remove-triage accepted |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues. This bot triages un-triaged issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues. This bot triages un-triaged issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /close not-planned |
@k8s-triage-robot: Closing this issue, marking it as "Not Planned". In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/reopen |
@devstein: You can't reopen an issue/PR unless you authored it or you are a collaborator. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This umbrella issue tracks user feedback for the new alpha command
kustomize localize
.The text was updated successfully, but these errors were encountered: