Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't use kustomize vars in images #1592

Closed
kkasravi opened this issue Oct 6, 2019 · 5 comments
Closed

Can't use kustomize vars in images #1592

kkasravi opened this issue Oct 6, 2019 · 5 comments
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@kkasravi
Copy link

kkasravi commented Oct 6, 2019

use case

params.env

registry=gcr.io
centraldashboardImageName=kubeflow-images-public/centraldashboard
centraldashboardImageTag=v20190823-v0.6.0-rc.0-69-gcb7dab59

params.yaml

- path: images/name
  kind: Kustomization
- path: images/newName
  kind: Kustomization
- path: images/newTag
  kind: Kustomization

kustomization.yaml

...
configMapGenerator:
- name: parameters
  env: params.env
vars:
- name: registry
  objref:
    kind: ConfigMap
    name: parameters
    apiVersion: v1
  fieldref:
    fieldpath: data.registry
- name: centraldashboardImageName
  objref:
    kind: ConfigMap
    name: parameters
    apiVersion: v1
  fieldref:
    fieldpath: data.centraldashboardImageName
- name: centraldashboardImageTag
  objref:
    kind: ConfigMap
    name: parameters
    apiVersion: v1
  fieldref:
    fieldpath: data.centraldashboardImageTag
configurations:
- params.yaml
images:
  - name: $(registry)/$(centraldashboardImageName)
    newName: $(registry)/$(centraldashboardImageName)
    newTag: $(centraldashboardImageTag)
@jbrette
Copy link
Contributor

jbrette commented Oct 6, 2019

A possible solution here

For info the Kustomization kind object does not have any meta-data name so can not be loaded as resource. Could be interesting to add such as metadata field

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 4, 2020
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Feb 3, 2020
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

@k8s-ci-robot
Copy link
Contributor

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

4 participants