Skip to content

Commit

Permalink
fix: changes from code review
Browse files Browse the repository at this point in the history
* Replace last assert directive with require in the test.
* Change copyright notice.
  • Loading branch information
stormqueen1990 committed Sep 20, 2023
1 parent 0571a2f commit 9107fa3
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 5 deletions.
2 changes: 1 addition & 1 deletion kustomize/commands/edit/remove/removeconfigmap.go
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Copyright 2022 The Kubernetes Authors.
// Copyright 2023 The Kubernetes Authors.
// SPDX-License-Identifier: Apache-2.0

package remove
Expand Down
6 changes: 2 additions & 4 deletions kustomize/commands/edit/remove/removeconfigmap_test.go
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Copyright 2022 The Kubernetes Authors.
// Copyright 2023 The Kubernetes Authors.
// SPDX-License-Identifier: Apache-2.0

package remove //nolint:testpackage
Expand All @@ -8,8 +8,6 @@ import (
"testing"

"github.com/stretchr/testify/require"

"github.com/stretchr/testify/assert"
testutils_test "sigs.k8s.io/kustomize/kustomize/v5/commands/internal/testutils"
"sigs.k8s.io/kustomize/kyaml/filesys"
)
Expand Down Expand Up @@ -105,7 +103,7 @@ kind: Kustomization

if tc.expectedErr != "" {
require.Error(t, err)
assert.Contains(t, err.Error(), tc.expectedErr)
require.Contains(t, err.Error(), tc.expectedErr)
return
}

Expand Down

0 comments on commit 9107fa3

Please sign in to comment.