Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated containerd migration to work when etcd_kubeadm_enabled is set #8528

Closed
wants to merge 1 commit into from
Closed

Updated containerd migration to work when etcd_kubeadm_enabled is set #8528

wants to merge 1 commit into from

Conversation

Xartos
Copy link
Contributor

@Xartos Xartos commented Feb 10, 2022

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

The containerd migration documentation didn't really work with a cluster that had etcd_kubeadm_enabled set to true.
This PR tries to fix that.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@k8s-ci-robot k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 10, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @Xartos. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 10, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Xartos
To complete the pull request process, please assign floryut after the PR has been reviewed.
You can assign the PR to them by writing /assign @floryut in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Xartos Xartos mentioned this pull request Feb 10, 2022
Closed
cristicalin
cristicalin reviewed Feb 14, 2022
View reviewed changes
docs/upgrades/migrate_docker2containerd.md
>
> ```diff
> - image: quay.io/coreos/etcd:v3.4.13
> + image: quay.io/coreos/etcd:v3.5.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strictly speaking this is not related to the docker to containerd migration but kube version upgrade.

Copy link
Contributor Author

@Xartos Xartos Feb 14, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, your are correct. I wounder if this is a non issue if you first upgraded to 2.18 and then migrate to containerd 🤔
I'll need to test to verify this

Copy link
Contributor Author

@Xartos Xartos Feb 15, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I just verified this. So upgrading first and then migrate according to the documentation works great.
Seems like I was just a little bit to greedy and tried to upgrade from 2.17.1 -> 2.18.0 at the same time as this migration and then this doesn't work.
I'll close the PR

@cristicalin
Copy link
Contributor

@Xartos 👍

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 14, 2022
@Xartos Xartos closed this Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cristicalin cristicalin cristicalin left review comments

@holmsten holmsten Awaiting requested review from holmsten

@jayonlau jayonlau Awaiting requested review from jayonlau

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Xartos @k8s-ci-robot @cristicalin