Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide initial guidelines for a container engine migration #8471

Merged
merged 1 commit into from
Jan 27, 2022
Merged

Provide initial guidelines for a container engine migration #8471

merged 1 commit into from
Jan 27, 2022

Conversation

juliohm1978
Copy link
Contributor

Follow up from #8431.

Signed-off-by: Julio Morimoto julio@morimoto.net.br

What this PR does / why we need it: While the procedure is not actually supported by Kubespray, manual steps can be used to achieve the migration. Docs can be used to provide an initial alternative and have been dosed with warnings about how unsafe this can be at the moment.

Which issue(s) this PR fixes:

Follow up from #8431

Special notes for your reviewer:

Feel free to modify and adapt the contents. My wording is not always up with the expected tone.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 25, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @juliohm1978. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@juliohm1978 juliohm1978 mentioned this pull request Jan 25, 2022
Closed
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 25, 2022
@juliohm1978 juliohm1978 force-pushed the master branch 2 times, most recently from 852d00d to 0330667 Compare January 25, 2022 21:14
@cristicalin
Copy link
Contributor

Awesome! Thanks for giving some love to our docs @juliohm1978 !

/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 26, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 26, 2022
oomichi
oomichi reviewed Jan 26, 2022
View reviewed changes
Copy link
Contributor

@oomichi oomichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for providing actual steps for switching container engine.
That is really helpful.
Just few comments on that.

/approve

docs/upgrades/migrate_docker2containerd.md

## Tested environment

Nodes: Ubuntu 18.04 LTS\
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is \ a the end of this line?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It adds line breaks without any spacing onto the following line. Keeps them closer together as a single paragraph.

docs/upgrades/migrate_docker2containerd.md
## Tested environment

Nodes: Ubuntu 18.04 LTS\
Cloud Provider: None (baremetal or VMs)\
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

docs/upgrades/migrate_docker2containerd.md

Nodes: Ubuntu 18.04 LTS\
Cloud Provider: None (baremetal or VMs)\
Kubernetes version: 1.21.5\
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

docs/upgrades/migrate_docker2containerd.md Outdated
### 1) Pick one or more nodes for processing
It is still unclear how the order might affect this procedure. So, to be sure, it might be best to start with master and etcd nodes all together, followed by each worker node individually.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/master/control plane/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. The commit has been amended.

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 26, 2022
@oomichi
Copy link
Contributor

oomichi commented Jan 26, 2022

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 26, 2022
@oomichi
Copy link
Contributor

oomichi commented Jan 26, 2022

Feel free to cancel hold after updating.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 26, 2022
@juliohm1978
Provide initial guidelines for a container engine migration (docker-2…
e094216 
…-containerd), with special emphasis on the fact that the procedure is still not officially supported.

Follow up from kubernetes-sigs#8431.

Signed-off-by: Julio Morimoto <julio@morimoto.net.br>
@oomichi
Copy link
Contributor

oomichi commented Jan 26, 2022

Thanks for updating.

/lgtm
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 26, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 26, 2022
floryut
floryut approved these changes Jan 27, 2022
View reviewed changes
Copy link
Member

@floryut floryut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@juliohm1978 Good work 🙇

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, juliohm1978, oomichi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit b0eb565 into kubernetes-sigs:master Jan 27, 2022
juliohm1978 added a commit to jhmorimoto/kubespray that referenced this pull request Jan 28, 2022
@juliohm1978
Amend PR kubernetes-sigs#8471 with missing inventory configuration.
7772ce6 
Signed-off-by: Julio Morimoto <julio@morimoto.net.br>
@juliohm1978 juliohm1978 mentioned this pull request Jan 28, 2022
Merged
juliohm1978 added a commit to jhmorimoto/kubespray that referenced this pull request Jan 28, 2022
@juliohm1978
Amend PR kubernetes-sigs#8471 with missing inventory configuration.
af83a7c 
Signed-off-by: Julio Morimoto <julio@morimoto.net.br>
juliohm1978 added a commit to jhmorimoto/kubespray that referenced this pull request Jan 29, 2022
@juliohm1978
Amend PR kubernetes-sigs#8471 with missing inventory configuration.
cd86c68 
Signed-off-by: Julio Morimoto <julio@morimoto.net.br>
k8s-ci-robot pushed a commit that referenced this pull request Feb 2, 2022
@juliohm1978
Amend documentation for docker to containerd migration (#8477)
eac799f 
* Amend PR #8471 with missing inventory configuration.

Signed-off-by: Julio Morimoto <julio@morimoto.net.br>

* Amend PR #8471 with missing inventory configuration.

Signed-off-by: Julio Morimoto <julio@morimoto.net.br>
sakuraiyuta pushed a commit to sakuraiyuta/kubespray that referenced this pull request Apr 16, 2022
@juliohm1978 @sakuraiyuta
Provide initial guidelines for a container engine migration (docker-2…
619db07 
…-containerd), with special emphasis on the fact that the procedure is still not officially supported. (kubernetes-sigs#8471)

Follow up from kubernetes-sigs#8431.

Signed-off-by: Julio Morimoto <julio@morimoto.net.br>
sakuraiyuta pushed a commit to sakuraiyuta/kubespray that referenced this pull request Apr 16, 2022
@juliohm1978 @sakuraiyuta
Amend documentation for docker to containerd migration (kubernetes-si…
7854535 
…gs#8477)

* Amend PR kubernetes-sigs#8471 with missing inventory configuration.

Signed-off-by: Julio Morimoto <julio@morimoto.net.br>

* Amend PR kubernetes-sigs#8471 with missing inventory configuration.

Signed-off-by: Julio Morimoto <julio@morimoto.net.br>
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jun 29, 2023
@juliohm1978 @LuckySB
Provide initial guidelines for a container engine migration (docker-2…
b41079f 
…-containerd), with special emphasis on the fact that the procedure is still not officially supported. (kubernetes-sigs#8471)

Follow up from kubernetes-sigs#8431.

Signed-off-by: Julio Morimoto <julio@morimoto.net.br>
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jun 29, 2023
@juliohm1978 @LuckySB
Amend documentation for docker to containerd migration (kubernetes-si…
4f0f267 
…gs#8477)

* Amend PR kubernetes-sigs#8471 with missing inventory configuration.

Signed-off-by: Julio Morimoto <julio@morimoto.net.br>

* Amend PR kubernetes-sigs#8471 with missing inventory configuration.

Signed-off-by: Julio Morimoto <julio@morimoto.net.br>
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Oct 20, 2023
@juliohm1978 @LuckySB
Provide initial guidelines for a container engine migration (docker-2…
769d8f9 
…-containerd), with special emphasis on the fact that the procedure is still not officially supported. (kubernetes-sigs#8471)

Follow up from kubernetes-sigs#8431.

Signed-off-by: Julio Morimoto <julio@morimoto.net.br>
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Oct 21, 2023
@juliohm1978 @LuckySB
Amend documentation for docker to containerd migration (kubernetes-si…
ac98a40 
…gs#8477)

* Amend PR kubernetes-sigs#8471 with missing inventory configuration.

Signed-off-by: Julio Morimoto <julio@morimoto.net.br>

* Amend PR kubernetes-sigs#8471 with missing inventory configuration.

Signed-off-by: Julio Morimoto <julio@morimoto.net.br>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oomichi oomichi oomichi left review comments

@floryut floryut floryut approved these changes

@jayonlau jayonlau Awaiting requested review from jayonlau

Assignees

@oomichi oomichi

@cristicalin cristicalin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@juliohm1978 @k8s-ci-robot @cristicalin @oomichi @floryut