Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.11] fix broken scale procedure #5926

Merged
merged 2 commits into from
Apr 29, 2020

Conversation

mariob1626
Copy link

@mariob1626 mariob1626 commented Apr 9, 2020

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change

/kind bug

/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
Playbook scale.yml broken when etcd_kubeadm_enabled == true on task etcd/tasks/install_host.yml
kublet not started with docker because the wrong cgroup_driver: systemd in config

Which issue(s) this PR fixes:

Fixes #5262

Special notes for your reviewer:
This was merged in v2.12 and would fix the same in v2.11

Does this PR introduce a user-facing change?:

NONE


- remove default value 'systemd' for cgroup driver in containerd role.
  this value override autodetect in kubelet_cgroup_driver_detected from docker info
do not run etcd role when etcd_kubeadm_enabled == true
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 9, 2020
@k8s-ci-robot
Copy link
Contributor

Welcome @mariobris!

It looks like this is your first PR to kubernetes-sigs/kubespray 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubespray has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @mariobris. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 9, 2020
@k8s-ci-robot k8s-ci-robot requested review from holmsten and mirwan April 9, 2020 18:33
@mariob1626 mariob1626 changed the title Release 2.11 fix broken scale procedure Apr 9, 2020
@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Apr 9, 2020
@Miouge1
Copy link
Contributor

Miouge1 commented Apr 10, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 10, 2020
@mariob1626 mariob1626 changed the title fix broken scale procedure [2.11] fix broken scale procedure Apr 10, 2020
@mariob1626
Copy link
Author

Hi @mirwan, @holmsten I see you as reviewers so just checking if should just wait or missing something.

@holmsten
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 14, 2020
@Miouge1
Copy link
Contributor

Miouge1 commented Apr 14, 2020

@mariobris can you link to the PRs that fix that in master or release-2.12? (for reference)

@mariob1626
Copy link
Author

@Miouge1
Copy link
Contributor

Miouge1 commented Apr 16, 2020

@LuckySB as the original author of #5193 you might want to review this PR?

/assign @LuckySB

@LuckySB
Copy link
Contributor

LuckySB commented Apr 16, 2020

@LuckySB as the original author of #5193 you might want to review this PR?

/assign @LuckySB

/approve

ps: but i do not have right to approve in release 2.11 (

@mariob1626
Copy link
Author

mariob1626 commented Apr 17, 2020

/assign @mattymo could you help with this ?

@Miouge1
Copy link
Contributor

Miouge1 commented Apr 17, 2020

/assign

I can take care of this, but I want to test it first.

@woopstar
Copy link
Member

ok to merge? @Miouge1 ?

@woopstar
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LuckySB, mariobris, woopstar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 29, 2020
@k8s-ci-robot k8s-ci-robot merged commit 67167bd into kubernetes-sigs:release-2.11 Apr 29, 2020
@mariob1626 mariob1626 deleted the release-2.11 branch April 29, 2020 15:43
@mariob1626 mariob1626 restored the release-2.11 branch April 29, 2020 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants