-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2.11] fix broken scale procedure #5926
[2.11] fix broken scale procedure #5926
Conversation
- remove default value 'systemd' for cgroup driver in containerd role. this value override autodetect in kubelet_cgroup_driver_detected from docker info
do not run etcd role when etcd_kubeadm_enabled == true
Welcome @mariobris! |
Hi @mariobris. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/lgtm |
@mariobris can you link to the PRs that fix that in master or release-2.12? (for reference) |
@Miouge1 https://github.com/kubernetes-sigs/kubespray/pull/5193/files if it's ok like this |
/assign @mattymo could you help with this ? |
/assign I can take care of this, but I want to test it first. |
ok to merge? @Miouge1 ? |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: LuckySB, mariobris, woopstar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Playbook scale.yml broken when etcd_kubeadm_enabled == true on task etcd/tasks/install_host.yml
kublet not started with docker because the wrong cgroup_driver: systemd in config
Which issue(s) this PR fixes:
Fixes #5262
Special notes for your reviewer:
This was merged in v2.12 and would fix the same in v2.11
Does this PR introduce a user-facing change?:
NONE