Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove hostnameOverride from kube-proxy config. #3612

Closed
wants to merge 1 commit into from
Closed

Remove hostnameOverride from kube-proxy config. #3612

wants to merge 1 commit into from

Conversation

pslijkhuis
Copy link
Contributor

This fixes #3610

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: mattymo

If they are not already assigned, you can assign the PR to them by writing /assign @mattymo in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 30, 2018
@woopstar
Copy link
Member

ci check this

mirwan
mirwan suggested changes Nov 6, 2018
View reviewed changes
Copy link
Contributor

@mirwan mirwan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overriding hostname may be required in some environments.
There is a workaround to this issue: https://kubernetes.io/docs/setup/independent/troubleshooting-kubeadm/#services-with-externaltrafficpolicy-local-are-not-reachable
There are some patches related to kubeadm in win_nodes role.
Could you provide such patch as well?

@mirwan
Copy link
Contributor

mirwan commented Nov 8, 2018

@pslijkhuis Any update on this one?

@mirwan mirwan mentioned this pull request Nov 14, 2018
Merged
@woopstar woopstar closed this Nov 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirwan mirwan mirwan requested changes

@chapsuk chapsuk Awaiting requested review from chapsuk

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

hostnameOverride in kube-proxy configmap shouldn't be set.
4 participants
@pslijkhuis @k8s-ci-robot @woopstar @mirwan