Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Revert "Make kubebuilder go install-able" #4576

Merged
merged 1 commit into from
Feb 21, 2025

Conversation

camilamacedo86
Copy link
Member

Reverts #4481

We need to revert this one, see that after we do a pre-release to test it out it fails: #4575

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 21, 2025
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 21, 2025
@camilamacedo86 camilamacedo86 changed the title Revert ":bug: Make kubebuilder go install-able" 🐛 Revert "🐛 Make kubebuilder go install-able" Feb 21, 2025
@camilamacedo86 camilamacedo86 changed the title 🐛 Revert "🐛 Make kubebuilder go install-able" 🐛 Revert "Make kubebuilder go install-able" Feb 21, 2025
@camilamacedo86
Copy link
Member Author

Moving forward with the revert to allow us to do the patch release 4.5.1

@camilamacedo86 camilamacedo86 added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 21, 2025
@k8s-ci-robot k8s-ci-robot merged commit 0ace7a8 into master Feb 21, 2025
31 of 32 checks passed
@camilamacedo86 camilamacedo86 deleted the revert-4481-make-go-install-able branch February 21, 2025 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants