-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Fix kubebuild alpha generate when not in GOPATH #4559
Conversation
…running kubebuilder init to fix issue when not on GOPATH
Welcome @freddyesteban! |
Hi @freddyesteban. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/ok-to-test
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, freddyesteban The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ran to an issue when running
kubebuilder alpha generate
, and since my project was not on the GOPATH, there was no implicit call togo mod init
.This change updates
alpha generate
command so that--repo
is always included when running kubebuilder init to fix issue when not on GOPATH. The value forrepo
is retrieved from the PROJECT file as other kubebuilder init options.