Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ (kustomize/v2) feat: add app.kubernetes.io/name label to allow more precise configurations #4437

Merged
merged 1 commit into from
Dec 25, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -15,3 +15,4 @@ spec:
targetPort: 8443
selector:
control-plane: controller-manager
app.kubernetes.io/name: project
Original file line number Diff line number Diff line change
Expand Up @@ -20,13 +20,15 @@ spec:
selector:
matchLabels:
control-plane: controller-manager
app.kubernetes.io/name: project
replicas: 1
template:
metadata:
annotations:
kubectl.kubernetes.io/default-container: manager
labels:
control-plane: controller-manager
app.kubernetes.io/name: project
spec:
# TODO(user): Uncomment the following code to configure the nodeAffinity expression
# according to the platforms which are supported by your solution.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ spec:
podSelector:
matchLabels:
control-plane: controller-manager
app.kubernetes.io/name: project
policyTypes:
- Ingress
ingress:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ spec:
podSelector:
matchLabels:
control-plane: controller-manager
app.kubernetes.io/name: project
policyTypes:
- Ingress
ingress:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,3 +24,4 @@ spec:
selector:
matchLabels:
control-plane: controller-manager
app.kubernetes.io/name: project
Original file line number Diff line number Diff line change
Expand Up @@ -13,3 +13,4 @@ spec:
targetPort: 9443
selector:
control-plane: controller-manager
app.kubernetes.io/name: project
Original file line number Diff line number Diff line change
Expand Up @@ -4074,6 +4074,7 @@ spec:
protocol: TCP
targetPort: 8443
selector:
app.kubernetes.io/name: project
control-plane: controller-manager
---
apiVersion: v1
Expand All @@ -4090,6 +4091,7 @@ spec:
protocol: TCP
targetPort: 9443
selector:
app.kubernetes.io/name: project
control-plane: controller-manager
---
apiVersion: apps/v1
Expand All @@ -4105,12 +4107,14 @@ spec:
replicas: 1
selector:
matchLabels:
app.kubernetes.io/name: project
control-plane: controller-manager
template:
metadata:
annotations:
kubectl.kubernetes.io/default-container: manager
labels:
app.kubernetes.io/name: project
control-plane: controller-manager
spec:
containers:
Expand Down Expand Up @@ -4252,6 +4256,7 @@ spec:
name: metrics-server-cert
selector:
matchLabels:
app.kubernetes.io/name: project
control-plane: controller-manager
---
apiVersion: admissionregistration.k8s.io/v1
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,3 +15,4 @@ spec:
targetPort: 8443
selector:
control-plane: controller-manager
app.kubernetes.io/name: project
Original file line number Diff line number Diff line change
Expand Up @@ -20,13 +20,15 @@ spec:
selector:
matchLabels:
control-plane: controller-manager
app.kubernetes.io/name: project
replicas: 1
template:
metadata:
annotations:
kubectl.kubernetes.io/default-container: manager
labels:
control-plane: controller-manager
app.kubernetes.io/name: project
spec:
# TODO(user): Uncomment the following code to configure the nodeAffinity expression
# according to the platforms which are supported by your solution.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ spec:
podSelector:
matchLabels:
control-plane: controller-manager
app.kubernetes.io/name: project
policyTypes:
- Ingress
ingress:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,3 +24,4 @@ spec:
selector:
matchLabels:
control-plane: controller-manager
app.kubernetes.io/name: project
Original file line number Diff line number Diff line change
Expand Up @@ -393,6 +393,7 @@ spec:
protocol: TCP
targetPort: 8443
selector:
app.kubernetes.io/name: project
control-plane: controller-manager
---
apiVersion: apps/v1
Expand All @@ -408,12 +409,14 @@ spec:
replicas: 1
selector:
matchLabels:
app.kubernetes.io/name: project
control-plane: controller-manager
template:
metadata:
annotations:
kubectl.kubernetes.io/default-container: manager
labels:
app.kubernetes.io/name: project
control-plane: controller-manager
spec:
containers:
Expand Down Expand Up @@ -478,4 +481,5 @@ spec:
insecureSkipVerify: true
selector:
matchLabels:
app.kubernetes.io/name: project
control-plane: controller-manager
Original file line number Diff line number Diff line change
Expand Up @@ -15,3 +15,4 @@ spec:
targetPort: 8443
selector:
control-plane: controller-manager
app.kubernetes.io/name: project
Original file line number Diff line number Diff line change
Expand Up @@ -20,13 +20,15 @@ spec:
selector:
matchLabels:
control-plane: controller-manager
app.kubernetes.io/name: project
replicas: 1
template:
metadata:
annotations:
kubectl.kubernetes.io/default-container: manager
labels:
control-plane: controller-manager
app.kubernetes.io/name: project
spec:
# TODO(user): Uncomment the following code to configure the nodeAffinity expression
# according to the platforms which are supported by your solution.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ spec:
podSelector:
matchLabels:
control-plane: controller-manager
app.kubernetes.io/name: project
policyTypes:
- Ingress
ingress:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ spec:
podSelector:
matchLabels:
control-plane: controller-manager
app.kubernetes.io/name: project
policyTypes:
- Ingress
ingress:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,3 +24,4 @@ spec:
selector:
matchLabels:
control-plane: controller-manager
app.kubernetes.io/name: project
Original file line number Diff line number Diff line change
Expand Up @@ -13,3 +13,4 @@ spec:
targetPort: 9443
selector:
control-plane: controller-manager
app.kubernetes.io/name: project
Original file line number Diff line number Diff line change
Expand Up @@ -7885,6 +7885,7 @@ spec:
protocol: TCP
targetPort: 8443
selector:
app.kubernetes.io/name: project
control-plane: controller-manager
---
apiVersion: v1
Expand All @@ -7901,6 +7902,7 @@ spec:
protocol: TCP
targetPort: 9443
selector:
app.kubernetes.io/name: project
control-plane: controller-manager
---
apiVersion: apps/v1
Expand All @@ -7916,12 +7918,14 @@ spec:
replicas: 1
selector:
matchLabels:
app.kubernetes.io/name: project
control-plane: controller-manager
template:
metadata:
annotations:
kubectl.kubernetes.io/default-container: manager
labels:
app.kubernetes.io/name: project
control-plane: controller-manager
spec:
containers:
Expand Down Expand Up @@ -8063,6 +8067,7 @@ spec:
name: metrics-server-cert
selector:
matchLabels:
app.kubernetes.io/name: project
control-plane: controller-manager
---
apiVersion: admissionregistration.k8s.io/v1
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -58,4 +58,5 @@ spec:
targetPort: 8443
selector:
control-plane: controller-manager
app.kubernetes.io/name: {{ .ProjectName }}
`
Original file line number Diff line number Diff line change
Expand Up @@ -66,13 +66,15 @@ spec:
selector:
matchLabels:
control-plane: controller-manager
app.kubernetes.io/name: {{ .ProjectName }}
replicas: 1
template:
metadata:
annotations:
kubectl.kubernetes.io/default-container: manager
labels:
control-plane: controller-manager
app.kubernetes.io/name: {{ .ProjectName }}
spec:
# TODO(user): Uncomment the following code to configure the nodeAffinity expression
# according to the platforms which are supported by your solution.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ spec:
podSelector:
matchLabels:
control-plane: controller-manager
app.kubernetes.io/name: {{ .ProjectName }}
policyTypes:
- Ingress
ingress:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ spec:
podSelector:
matchLabels:
control-plane: controller-manager
app.kubernetes.io/name: {{ .ProjectName }}
policyTypes:
- Ingress
ingress:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -68,4 +68,5 @@ spec:
selector:
matchLabels:
control-plane: controller-manager
app.kubernetes.io/name: {{ .ProjectName }}
`
Original file line number Diff line number Diff line change
Expand Up @@ -59,4 +59,5 @@ spec:
targetPort: 9443
selector:
control-plane: controller-manager
app.kubernetes.io/name: {{ .ProjectName }}
`
Original file line number Diff line number Diff line change
Expand Up @@ -15,3 +15,4 @@ spec:
targetPort: 8443
selector:
control-plane: controller-manager
app.kubernetes.io/name: project-v4-multigroup
2 changes: 2 additions & 0 deletions testdata/project-v4-multigroup/config/manager/manager.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -20,13 +20,15 @@ spec:
selector:
matchLabels:
control-plane: controller-manager
app.kubernetes.io/name: project-v4-multigroup
replicas: 1
template:
metadata:
annotations:
kubectl.kubernetes.io/default-container: manager
labels:
control-plane: controller-manager
app.kubernetes.io/name: project-v4-multigroup
spec:
# TODO(user): Uncomment the following code to configure the nodeAffinity expression
# according to the platforms which are supported by your solution.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ spec:
podSelector:
matchLabels:
control-plane: controller-manager
app.kubernetes.io/name: project-v4-multigroup
policyTypes:
- Ingress
ingress:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ spec:
podSelector:
matchLabels:
control-plane: controller-manager
app.kubernetes.io/name: project-v4-multigroup
policyTypes:
- Ingress
ingress:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,3 +24,4 @@ spec:
selector:
matchLabels:
control-plane: controller-manager
app.kubernetes.io/name: project-v4-multigroup
1 change: 1 addition & 0 deletions testdata/project-v4-multigroup/config/webhook/service.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,3 +13,4 @@ spec:
targetPort: 9443
selector:
control-plane: controller-manager
app.kubernetes.io/name: project-v4-multigroup
4 changes: 4 additions & 0 deletions testdata/project-v4-multigroup/dist/install.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2071,6 +2071,7 @@ spec:
protocol: TCP
targetPort: 8443
selector:
app.kubernetes.io/name: project-v4-multigroup
control-plane: controller-manager
---
apiVersion: v1
Expand All @@ -2087,6 +2088,7 @@ spec:
protocol: TCP
targetPort: 9443
selector:
app.kubernetes.io/name: project-v4-multigroup
control-plane: controller-manager
---
apiVersion: apps/v1
Expand All @@ -2102,12 +2104,14 @@ spec:
replicas: 1
selector:
matchLabels:
app.kubernetes.io/name: project-v4-multigroup
control-plane: controller-manager
template:
metadata:
annotations:
kubectl.kubernetes.io/default-container: manager
labels:
app.kubernetes.io/name: project-v4-multigroup
control-plane: controller-manager
spec:
containers:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,3 +15,4 @@ spec:
targetPort: 8443
selector:
control-plane: controller-manager
app.kubernetes.io/name: project-v4-with-plugins
2 changes: 2 additions & 0 deletions testdata/project-v4-with-plugins/config/manager/manager.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -20,13 +20,15 @@ spec:
selector:
matchLabels:
control-plane: controller-manager
app.kubernetes.io/name: project-v4-with-plugins
replicas: 1
template:
metadata:
annotations:
kubectl.kubernetes.io/default-container: manager
labels:
control-plane: controller-manager
app.kubernetes.io/name: project-v4-with-plugins
spec:
# TODO(user): Uncomment the following code to configure the nodeAffinity expression
# according to the platforms which are supported by your solution.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ spec:
podSelector:
matchLabels:
control-plane: controller-manager
app.kubernetes.io/name: project-v4-with-plugins
policyTypes:
- Ingress
ingress:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ spec:
podSelector:
matchLabels:
control-plane: controller-manager
app.kubernetes.io/name: project-v4-with-plugins
policyTypes:
- Ingress
ingress:
Expand Down
Loading
Loading