-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📖 refactor: finalizer in CronJob example #4397
base: master
Are you sure you want to change the base?
Changes from 1 commit
99da1bb
5bdafe0
c767eca
44088d9
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
- Loading branch information
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -76,6 +76,14 @@ func (r *CronJobReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ct | |
if err := r.Update(ctx, cronJob); err != nil { | ||
return ctrl.Result{}, err | ||
} | ||
|
||
// we re-fetch after having updated the CronJob, so that we have the latest | ||
// state of the resource, and avoid the error "the object has been modified, | ||
// please apply your changes to the latest version and try again". | ||
if err := r.Get(ctx, req.NamespacedName, cronJob); err != nil { | ||
log.Error(err, "unable to fetch CronJob") | ||
return ctrl.Result{}, client.IgnoreNotFound(err) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. would not be better to always error out here? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes you are right. We need to change it in the deploy image too. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. may I ask why? If in the meantime the resource was deleted shouldn't that be ignored? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. On top we should have : https://github.com/kubernetes-sigs/kubebuilder/blob/cbc6e383c342f1337ab37ee4aa0755957a01f9c7/testdata/project-v4-with-plugins/internal/controller/busybox_controller.go#L84C2-L99C3 If the resource is deleted, then the reconciliation stop at this point. What we need to do is fix the tutorials to have the structure of https://github.com/kubernetes-sigs/kubebuilder/blob/master/testdata/project-v4-with-plugins/internal/controller/busybox_controller.go The changes here seems for me either incomplete if we address only the finalizer |
||
} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thank you for the contribution 🥇 See that: We need to change the code under hack/docs so that when we run Therefore, can you please add the code there and run the command to ensure that all is fine? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Indeed it will result in multi-version and crojob tutorial changed when you run |
||
} | ||
} else { | ||
// The object is being deleted | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would be better to say
re-fetch
here?