Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Fix simplify external plugin tests #4233

Conversation

camilamacedo86
Copy link
Member

@camilamacedo86 camilamacedo86 commented Oct 29, 2024

  • Bump sigs.k8s.io/kubebuilder/v4 from 4.2.0 to 4.3.0 in /docs/book/src/simple-external-plugin-tutorial/testdata/sampleexternalplugin/v1.
  • Resolve compatibility by moving tests to GitHub Actions to use source code directly.
  • Remove external plugin e2e tests, as they do not run against a cluster, reducing complexity without testing across all k8s versions.

Closes: #4232

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 29, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 29, 2024
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 29, 2024
@camilamacedo86 camilamacedo86 force-pushed the fix-simplify-external-plugin-tests branch 5 times, most recently from e6e95e0 to 99ddae1 Compare October 29, 2024 06:38
…v4.3.0 in the doc sample used

- Bump sigs.k8s.io/kubebuilder/v4 from 4.2.0 to 4.3.0 in /docs/book/src/simple-external-plugin-tutorial/testdata/sampleexternalplugin/v1.
- Resolve compatibility by moving tests to GitHub Actions to use source code directly.
- Remove external plugin e2e tests, as they do not run against a cluster, reducing complexity without testing across all k8s versions.
@camilamacedo86 camilamacedo86 force-pushed the fix-simplify-external-plugin-tests branch from 99ddae1 to cfd0dfc Compare October 29, 2024 09:01
@camilamacedo86 camilamacedo86 changed the title WIP: 🌱 Fix simplify external plugin tests 🌱 Fix simplify external plugin tests Oct 29, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 29, 2024
@camilamacedo86
Copy link
Member Author

I will not make nobody waste time with this one since it does not affected end users and we are just moving the tests for GitHub actions which make more sense for this case scenario and let us know to do the tests with the latest changes.

@camilamacedo86 camilamacedo86 added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 29, 2024
@k8s-ci-robot k8s-ci-robot merged commit 81cf04f into kubernetes-sigs:master Oct 29, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants