-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support flake.nix and flake.lock as allowed files when initializing a project #4487
Comments
Hi @atkrad, Thank you for raising this. 🥇 The check is only done when you create the project. If you add these files afterwards, the issue would not be raised. This aims to prevent users from scaffolding a project in a directory with files that could impact its functionality. However, IHMO we can change this implementation. See where it is currently done: kubebuilder init.go Instead of using an allowed list, we could implement a deny list. For example:
What do you think? Would you like to work on this? |
@camilamacedo86 I would love to give it a try @atkrad wanna try out? lmk! thanks |
Go forward, please feel free to raise a PR. |
Thanks @camilamacedo86 I made it via my alias |
/assign afzal442 |
@camilamacedo86: GitHub didn't allow me to assign the following users: afzal442. Note that only kubernetes-sigs members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/assign afzal442 |
@camilamacedo86: GitHub didn't allow me to assign the following users: afzal442. Note that only kubernetes-sigs members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/assign afzal442 |
What do you want to happen?
When I attempt to initialize a new project, I encounter the following error:
Error:
It seems that only specific files, such as
go.mod
,go.sum
, or Markdown files, are accepted in the target directory. However, many developers use Nix to manage dependencies, which requires files likeflake.nix
andflake.lock
to be present in the directory for dependency installation.To improve compatibility, it would be a good idea to accept
flake.nix
andflake.lock
as allowed files during project initialization.Extra Labels
No response
The text was updated successfully, but these errors were encountered: