Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

verify: cleanup & ignore generated config code #48

Merged
merged 2 commits into from
Sep 30, 2018
Merged

verify: cleanup & ignore generated config code #48

merged 2 commits into from
Sep 30, 2018

Conversation

BenTheElder
Copy link
Member

xref: #36 which needs this to pass verify

/kind cleanup

with this it now runs a bit nicer:

$ hack/verify-all.sh
verifying govet ...
verifying gofmt ...
verifying golint ...
verifying generated ...
verifying deps ...

All verify checks passed, congrats!

@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Sep 29, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 29, 2018
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 29, 2018
@BenTheElder BenTheElder mentioned this pull request Sep 29, 2018
Merged
krzyzacy
krzyzacy approved these changes Sep 30, 2018
View reviewed changes
Copy link

@krzyzacy krzyzacy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Sep 30, 2018
@BenTheElder
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 30, 2018
@k8s-ci-robot k8s-ci-robot merged commit ba79f43 into kubernetes-sigs:master Sep 30, 2018
@BenTheElder BenTheElder deleted the verify-fixes branch September 30, 2018 23:11
@BenTheElder BenTheElder mentioned this pull request Feb 21, 2020
Merged
yankay pushed a commit to yankay/kind that referenced this pull request Mar 17, 2022
@jayunit100
Update helpers.go (kubernetes-sigs#48)
4ff61ae
stg-0 pushed a commit to stg-0/kind that referenced this pull request Mar 14, 2023
@esierra-stratio
Merge pull request kubernetes-sigs#48 from esierra-stratio/feat/make_…
3938424 
…external_dns_optional

[EOS-10983] Make `external-dns` optional
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krzyzacy krzyzacy krzyzacy approved these changes

@munnerz munnerz Awaiting requested review from munnerz

Assignees

@krzyzacy krzyzacy

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BenTheElder @k8s-ci-robot @krzyzacy