-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Prevent NodeClaims from transitioning into Ready=Unknown
during deletion
#2052
fix: Prevent NodeClaims from transitioning into Ready=Unknown
during deletion
#2052
Conversation
… from going unknown during deletion
Ready=Unknown
during deletion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jonathan-innis, rschalo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Pull Request Test Coverage Report for Build 13665877630Details
💛 - Coveralls |
Fixes #2034
Description
Performs a no-op status condition update during finalization to prevent NodeClaims from going into
Ready=Unknown
during deletion.How was this change tested?
make presubmit
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.