Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Prevent NodeClaims from transitioning into Ready=Unknown during deletion #2052

Conversation

rschalo
Copy link
Contributor

@rschalo rschalo commented Mar 4, 2025

Fixes #2034

Description
Performs a no-op status condition update during finalization to prevent NodeClaims from going into Ready=Unknown during deletion.

How was this change tested?
make presubmit

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 4, 2025
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 4, 2025
@rschalo rschalo changed the title fix: bump status condition observed generations to prevent nodeclaims… fix: Prevent NodeClaims from transitioning into Ready=Unknown during deletion Mar 4, 2025
Copy link
Member

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 5, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jonathan-innis, rschalo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 5, 2025
@coveralls
Copy link

Pull Request Test Coverage Report for Build 13665877630

Details

  • 12 of 16 (75.0%) changed or added relevant lines in 1 file are covered.
  • 9 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.002%) to 81.641%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/controllers/nodeclaim/lifecycle/controller.go 12 16 75.0%
Files with Coverage Reduction New Missed Lines %
pkg/controllers/node/termination/controller.go 2 72.08%
pkg/controllers/provisioning/scheduling/preferences.go 7 86.52%
Totals Coverage Status
Change from base Build 13660139585: -0.002%
Covered Lines: 9481
Relevant Lines: 11613

💛 - Coveralls

@k8s-ci-robot k8s-ci-robot merged commit 91755d4 into kubernetes-sigs:main Mar 5, 2025
14 checks passed
DerekFrank pushed a commit to DerekFrank/karpenter-testing-fork that referenced this pull request Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nodeclaim stuck in Unknown readiness status due to generation mismatch
5 participants