perf: Unregister the topology domain when failing NodeClaim creation #1819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jonathan-innis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Pull Request Test Coverage Report for Build 11874714947Details
💛 - Coveralls |
jmdeal
pushed a commit
to jmdeal/karpenter
that referenced
this pull request
Nov 18, 2024
jmdeal
pushed a commit
to jmdeal/karpenter
that referenced
this pull request
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #N/A
Description
Unregister the topology domain when failing to create a NodeClaim so that we don't hold topology domains around for hostname. Prior to this change, we weren't removing a mock domain that we would create for a topology on NewNodeClaim(). As a result, we would continually expand the number of hostname domains, making hostnmae topology spread and hostname anti-affinity way more inefficient than it should have.
Before
Example: Debug Image showing ~53,000 domains after only a few seconds iterating in the scheduling loop
After
Example: Debug Image showing only a single domain after only a few seconds iterating in the scheduling loop
How was this change tested?
make presubmitBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.