Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add log for scheduling progress for long running scheduling sim… #1788

Merged
merged 5 commits into from
Oct 30, 2024
Merged

feat: add log for scheduling progress for long running scheduling sim… #1788

merged 5 commits into from
Oct 30, 2024

Conversation

njtran
Copy link
Contributor

@njtran njtran commented Oct 30, 2024

…ulations

Fixes #N/A

Description
This adds a log in case provisioning takes too long, and the user wants to know if scheduling is occurring

How was this change tested?
locally

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 30, 2024
jonathan-innis
jonathan-innis reviewed Oct 30, 2024
View reviewed changes
Copy link
Member

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments on the wording

@coveralls
Copy link

coveralls commented Oct 30, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11598853956

Details

  • 9 of 13 (69.23%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 80.918%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/controllers/controllers.go 0 1 0.0%
pkg/controllers/provisioning/scheduling/scheduler.go 7 10 70.0%
Totals Coverage Status
Change from base Build 11584810194: 0.1%
Covered Lines: 8498
Relevant Lines: 10502
💛 - Coveralls

jonathan-innis
jonathan-innis approved these changes Oct 30, 2024
View reviewed changes
Copy link
Member

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 30, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jonathan-innis, njtran

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jonathan-innis,njtran]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit aa8c26d into kubernetes-sigs:main Oct 30, 2024
12 checks passed
jmdeal pushed a commit to jmdeal/karpenter that referenced this pull request Oct 30, 2024
@njtran @jmdeal
feat: add log for scheduling progress for long running scheduling sim… (
9354821 
kubernetes-sigs#1788)
@jmdeal jmdeal mentioned this pull request Oct 30, 2024
Merged
k8s-ci-robot pushed a commit that referenced this pull request Oct 30, 2024
@jmdeal @njtran
feat: add log for scheduling progress for long running scheduling sim…
008f465 
…ulations (#1788) (#1792)

Co-authored-by: Nick Tran <10810510+njtran@users.noreply.github.com>
engedaam pushed a commit to engedaam/karpenter-core that referenced this pull request Nov 10, 2024
@njtran @engedaam
feat: add log for scheduling progress for long running scheduling sim… (
43cfddb 
kubernetes-sigs#1788)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmdeal jmdeal jmdeal left review comments

@jonathan-innis jonathan-innis jonathan-innis approved these changes

@engedaam engedaam Awaiting requested review from engedaam

@tallaxes tallaxes Awaiting requested review from tallaxes

Assignees

@jonathan-innis jonathan-innis

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@njtran @coveralls @k8s-ci-robot @jmdeal @jonathan-innis