Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix webhook owner reference causing ArgoCD leak #1716

Conversation

jonathan-innis
Copy link
Member

@jonathan-innis jonathan-innis commented Sep 26, 2024

Fixes #N/A

Description

This change ensures that:

  1. Knative doesn't add ownerReferences to webhook configurations that it creates by adding DisableNamespaceOwnership to the webhook.Options
  2. We remove old OwnerReferences that were already added by Knative onto the webhook configuration resources by patching out the namespace ownership that was added by Knative

How was this change tested?

make presubmit

  • Ran this on an ArgoCD cluster where we started on v0.37.3, upgraded to this version and then upgraded to v1.0.3. This removed the webhook configurations and I validated that we removed the ownerReferences on this version

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 26, 2024
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 26, 2024
@jonathan-innis jonathan-innis force-pushed the fix-webhook-owner-ref branch 8 times, most recently from 7de7c2c to 4db54f5 Compare September 26, 2024 07:56
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 26, 2024
@jonathan-innis jonathan-innis force-pushed the fix-webhook-owner-ref branch 6 times, most recently from d0b991c to 100bb9c Compare September 26, 2024 17:12
@jonathan-innis jonathan-innis marked this pull request as ready for review September 26, 2024 17:23
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 26, 2024
@jonathan-innis
Copy link
Member Author

/hold Wait for patch releases to complete before merging

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 26, 2024
Copy link
Contributor

@njtran njtran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 1, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jonathan-innis, njtran

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jonathan-innis,njtran]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jonathan-innis
Copy link
Member Author

/unhold @njtran and @jmdeal have both looked and think the code looks good

@jonathan-innis
Copy link
Member Author

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 1, 2024
@k8s-ci-robot k8s-ci-robot merged commit 5bd3818 into kubernetes-sigs:release-v0.37.x Oct 1, 2024
11 of 12 checks passed
jonathan-innis added a commit to jonathan-innis/karpenter that referenced this pull request Oct 1, 2024
jonathan-innis added a commit to jonathan-innis/karpenter that referenced this pull request Oct 1, 2024
jonathan-innis added a commit to jonathan-innis/karpenter that referenced this pull request Oct 2, 2024
jonathan-innis added a commit to jonathan-innis/karpenter that referenced this pull request Oct 2, 2024
jonathan-innis added a commit to jonathan-innis/karpenter that referenced this pull request Oct 2, 2024
jonathan-innis added a commit to jonathan-innis/karpenter that referenced this pull request Oct 2, 2024
jonathan-innis added a commit to jonathan-innis/karpenter that referenced this pull request Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants