fix: Add compat annotation key when using NodePool's kubelet config compat annotation #1667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jonathan-innis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
86d11f0 to
5058055
Compare
engedaam
reviewed
Sep 16, 2024
5058055 to
8fb0954
Compare
8fb0954 to
b9f1b1e
Compare
8761b2d
into
kubernetes-sigs:release-v1.0.x
10 of 11 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes aws/karpenter-provider-aws#6987
Description
Ensure that we add the
compatability.karpenter.sh/v1beta1-kubelet-conversionis propagated onto NodeClaims when NodePool's use the kubelet configuration conversion during scheduling.Prior to this change, it was possible for the scheduler to call the GetInstanceTypes() API with one kubelet configuration (parsed by the the
compatability.karpenter.sh/v1beta1-kubelet-conversionannotation) which results in higher capacity/allocatable values to be passed to the scheduler. The NodeClaim wouldn't contain this annotation, though; so, when a CloudProvider goes to launch the NodeClaim or when the NodeClaim is considered later for capacity/allocatable, it might use a completely different set of values.This change ensures that the
compatability.karpenter.sh/v1beta1-kubelet-conversionso that the CloudProvider is able to reason about this Kubelet Config consistently across NodePools and NodeClaims.How was this change tested?
make presubmitBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.