-
Notifications
You must be signed in to change notification settings - Fork 502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add APISIX implementation #843
Add APISIX implementation #843
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the work on this! LGTM other than one tiny nit.
Looks like a flake with the kind cluster. /retest |
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com> Co-authored-by: James Peach <jpeach@apache.org>
42ea2e0
to
29b3354
Compare
/lgtm |
Thanks @tao12345666333! /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: robscott, tao12345666333 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Jintao Zhang zhangjintao9020@gmail.com
What type of PR is this?
/kind documentation
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: