-
Notifications
You must be signed in to change notification settings - Fork 509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump dependencies #824
Bump dependencies #824
Conversation
Hi @howardjohn. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: howardjohn, jpeach The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s.io/klog/v2 v2.10.0 | ||
k8s.io/utils v0.0.0-20210820185131-d34e5cb4466e | ||
sigs.k8s.io/controller-runtime v0.9.6 | ||
sigs.k8s.io/controller-tools v0.6.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI is failing for this because of my hack here: https://github.com/kubernetes-sigs/gateway-api/blob/master/hack/update-codegen.sh#L63
/ok-to-test |
Looks like it got a 503 trying to pull the golangci-lint image. /retest |
Not a flake this time: Uncommitted changes in generated sources: |
This doesn't impact any generate code. I don't have a strong motivation to do this (I was trying to fix something, no progress), but its good to stay latest
#830 should fix the failures once it's merged. |
/retest |
/lgtm |
This doesn't impact any generate code. I don't have a strong motivation
to do this (I was trying to fix something, no progress), but its good to
stay latest