Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define recommended conditions for policies #1682

Merged
merged 1 commit into from
Feb 3, 2023
Merged

Define recommended conditions for policies #1682

merged 1 commit into from
Feb 3, 2023

Conversation

mmamczur
Copy link
Contributor

What type of PR is this?

/kind feature
/kind gep

What this PR does / why we need it:

Add recommended conditions and reasons to policy_types.go. This follows the additions to GEP-713 made in #1673.

Which issue(s) this PR fixes:

Fixes #1641

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. kind/gep PRs related to Gateway Enhancement Proposal(GEP) cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 30, 2023
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 30, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @mmamczur. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

robscott
robscott reviewed Jan 31, 2023
View reviewed changes
Copy link
Member

@robscott robscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mmamczur!

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 31, 2023
@robscott robscott requested a review from shaneutt January 31, 2023 17:19
shaneutt
shaneutt approved these changes Jan 31, 2023
View reviewed changes
Copy link
Member

@shaneutt shaneutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once @robscott's comments are resolved, LGTM.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mmamczur, shaneutt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 31, 2023
@mmamczur
Define recommended conditions for policies
b41250a 
Add recommended conditions and reasons to policy_types.go. This follows the additions to GEP-713.
kubernetes-sigs#1641 (comment)
@mmamczur mmamczur force-pushed the policy_conditions_sources branch from 6e08cb4 to b41250a Compare February 1, 2023 09:54
@shaneutt shaneutt requested a review from robscott February 1, 2023 14:21
@robscott
Copy link
Member

robscott commented Feb 3, 2023

Thanks @mmamczur!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 3, 2023
@shaneutt shaneutt added this to the v0.6.1 milestone Feb 3, 2023
@k8s-ci-robot k8s-ci-robot merged commit e1b21a5 into kubernetes-sigs:main Feb 3, 2023
@shaneutt shaneutt modified the milestones: v0.6.1, v0.7.0 Feb 7, 2023
shaneutt pushed a commit that referenced this pull request Feb 7, 2023
@k8s-ci-robot @shaneutt
Merge pull request #1682 from mmamczur/policy_conditions_sources
9152db3 
Define recommended conditions for policies
@mmamczur mmamczur mentioned this pull request Aug 9, 2023
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shaneutt shaneutt shaneutt approved these changes

@bowei bowei Awaiting requested review from bowei

@youngnick youngnick Awaiting requested review from youngnick

@robscott robscott Awaiting requested review from robscott

Assignees

@robscott robscott

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. kind/gep PRs related to Gateway Enhancement Proposal(GEP) lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v0.6.1
Development

Successfully merging this pull request may close these issues.

Define common set of Policy conditions and reasons
4 participants
@mmamczur @k8s-ci-robot @robscott @shaneutt