Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename pkg/ext-proc to pkg/epp #372

Merged
merged 1 commit into from
Feb 19, 2025
Merged

Rename pkg/ext-proc to pkg/epp #372

merged 1 commit into from
Feb 19, 2025

Conversation

tchap
Copy link
Contributor

@tchap tchap commented Feb 19, 2025

This completes and fixes #348

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 19, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @tchap. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 19, 2025
@netlify Netlify
Copy link

netlify bot commented Feb 19, 2025 •
edited
Loading

✅ Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit 9832ec2
🔍 Latest deploy log https://app.netlify.com/sites/gateway-api-inference-extension/deploys/67b64baff767040008290acc
😎 Deploy Preview https://deploy-preview-372--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ahg-g
Copy link
Contributor

ahg-g commented Feb 19, 2025

Do you mind if we hold off merging this until #269 merges?

@ahg-g
Copy link
Contributor

ahg-g commented Feb 19, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 19, 2025
@tchap
Copy link
Contributor Author

tchap commented Feb 19, 2025

No prob for sure.

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 19, 2025
@tchap
Copy link
Contributor Author

tchap commented Feb 19, 2025

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 19, 2025
tchap
tchap commented Feb 19, 2025
View reviewed changes
pkg/epp/metrics/metrics_test.go
modelName: "m20",
targetModelName: "t20",
error: errutil.InferencePoolResourceExhausted,
}{
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just formatting, ignore.

@tchap
Copy link
Contributor Author

tchap commented Feb 19, 2025

@ahg-g The PR you mentioned is now merged, this is unblocked, rebased and ready.

@ahg-g
Copy link
Contributor

ahg-g commented Feb 19, 2025

/lgtm
/approve

Wonderful!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 19, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g, tchap

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 19, 2025
@k8s-ci-robot k8s-ci-robot merged commit 2577f63 into kubernetes-sigs:main Feb 19, 2025
8 checks passed
@tchap tchap deleted the rename-to-epp branch February 19, 2025 21:45
@JeffLuoo JeffLuoo mentioned this pull request Feb 19, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jeffwan Jeffwan Awaiting requested review from Jeffwan

@robscott robscott Awaiting requested review from robscott

Assignees

@ahg-g ahg-g

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rearrange directory structure of the repo
3 participants
@tchap @k8s-ci-robot @ahg-g