Fix for Openstack Designate and tests #522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lou-lan
pushed a commit
to lou-lan/external-dns
that referenced
this pull request
May 11, 2022
…s#522) * Move docs to the website * refactor README, USER_GUIDE, DEVELOPER_GUIDE with notes indicating they are moved to the website. * move installation instructions from README to the user guide. Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com> * document manifest naming Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com> * is -> has Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com> * Explain steps to distribute with Krew Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com> * add page on update checks Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com> * fix Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will finally fix Openstack Designate provider
I merged the Openstack PR but afterwards I realized the tests from Travis didn't pass, due to changes in our base code.
I changed only the necessary part which affected Travis from successfully testing and building.