Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typos #461

Merged
merged 1 commit into from
Feb 9, 2018
Merged

Typos #461

merged 1 commit into from
Feb 9, 2018

Conversation

eik3
Copy link
Contributor

@eik3 eik3 commented Feb 9, 2018

No description provided.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 9, 2018
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Feb 9, 2018
@Raffo
Copy link
Contributor

Raffo commented Feb 9, 2018

Typo fixes are always welcome :-)

Can you please sign the CLA?

@eik3
Copy link
Contributor Author

eik3 commented Feb 9, 2018

Signed

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Feb 9, 2018
@Raffo
Copy link
Contributor

Raffo commented Feb 9, 2018

👍

/cc @njuettner @linki

@njuettner
Copy link
Member

Thanks for fixing those typos :) ! 👍

@njuettner njuettner merged commit bd1aef2 into kubernetes-sigs:master Feb 9, 2018
@eik3 eik3 deleted the patch-1 branch February 15, 2018 19:14
grimmy pushed a commit to grimmy/external-dns that referenced this pull request Apr 10, 2018
lou-lan pushed a commit to lou-lan/external-dns that referenced this pull request May 11, 2022
* Create go.yml

* add install dependencies stage

* add GOPATH env var

* add new GOPATH env var

* add new GOPATH env var

* Update go.yml

* fix a run command

* Add with label

* Update go.yml

* Update go.yml

* Update go.yml

* Add specific GOPATH

* Update go.yml

* update all go env variables

* Update go.yml

* Update go.yml

* debug

* Update go.yml

* Update go.yml

* Update go.yml

* Update go.yml

* finish the first one

* add new config file to release stage

* fix config name

* Update release.yml

* build of artifacts to release

* Update release.yml

* Change push method

* v4.0.2

* new relese

* Update .github/workflows/push.yml

Co-Authored-By: Cornelius Weig <22861411+corneliusweig@users.noreply.github.com>

* Removing unnecessary sentences

* Update push.yml

* Update .github/workflows/release.yml

Co-Authored-By: Cornelius Weig <22861411+corneliusweig@users.noreply.github.com>

* Add setup-go to release file

* combining both configs into one

* combining both configs into one

* Fix identation

* add one run step

* Update push.yml

* Add new validation to release stage

* change tag condition

* Update push.yml

* change tag condition to release

* Update push.yml

* Update push.yml

* add build dependency to release stage

* Delete release.yml

* Update and rename push.yml to ci.yml

* change make all sentence to release stage

* copy make-all.sh in release stage

* Update ci.yml

* Delete release stage

join build & release stage

* refactor some code

* Rename steps

* delete release condition (not necessary)

Co-authored-by: Cornelius Weig <22861411+corneliusweig@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants