Enable and fix thelper linter

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
kubernetes-sigs · Dec 18, 2024 · c8dfcaa · c8dfcaa
1 parent 92bbcb8
commit c8dfcaa
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/.golangci.yml b/.golangci.yml
@@ -85,6 +85,7 @@ linters:
     - tenv
     - testableexamples
     - testifylint
+    - thelper
     - tparallel
     - typecheck
     - unconvert
@@ -109,7 +110,6 @@ linters:
     # - nlreturn
     # - nonamedreturns
     # - testpackage
-    # - thelper
     # - varnamelen
     # - wrapcheck
     # - wsl

diff --git a/cmd/critest/cri_test.go b/cmd/critest/cri_test.go
@@ -87,6 +87,7 @@ func isFlagSet(name string) bool {
 
 // runTestSuite runs cri validation tests and benchmark tests.
 func runTestSuite(t *testing.T) {
+	t.Helper()
 	gomega.RegisterFailHandler(ginkgo.Fail)
 	ginkgo.RunSpecs(t, "CRI validation")
 }
@@ -105,6 +106,7 @@ func generateTempTestName() (string, error) {
 }
 
 func runParallelTestSuite(t *testing.T) {
+	t.Helper()
 	criPath, err := os.Executable()
 	if err != nil {
 		t.Fatalf("Failed to lookup path of critest: %v", err)