Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Upgrade to go 1.19 and fix CI #722

Merged
merged 1 commit into from
Sep 14, 2022
Merged

✨ Upgrade to go 1.19 and fix CI #722

merged 1 commit into from
Sep 14, 2022

Conversation

Jefftree
Copy link
Member

@Jefftree Jefftree commented Sep 13, 2022 •
edited
Loading

Upgrade to go 1.19 and fix CI to pass.

The CI is currently broken on the latest master branch (See #720 and other PRs in the open PRs section.)

Steps:

Changed go.mod to 1.19
Upgraded golangci-lint to latest version (1.49.0)

go mod tidy
gofmt -s -w .

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Sep 13, 2022
@Jefftree
Copy link
Member Author

/cc @camilamacedo86
Is this something you can help with looking at? Thanks!

varshaprasad96
varshaprasad96 approved these changes Sep 13, 2022
View reviewed changes
Copy link
Member

@varshaprasad96 varshaprasad96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Sep 13, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 13, 2022
@k8s-triage-robot
Copy link

Unknown CLA label state. Rechecking for CLA labels.

Send feedback to sig-contributor-experience at kubernetes/community.

/check-cla
/easycla

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 14, 2022
camilamacedo86
camilamacedo86 approved these changes Sep 14, 2022
View reviewed changes
Copy link
Member

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that shows fine for me 🥇

/approved

@camilamacedo86
Copy link
Member

/lgtm

@camilamacedo86 camilamacedo86 added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 14, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: camilamacedo86, Jefftree, varshaprasad96

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 3379659 into kubernetes-sigs:master Sep 14, 2022
@camilamacedo86
Copy link
Member

closes: https://github.com/kubernetes-sigs/controller-tools/pull/713/files

@camilamacedo86 camilamacedo86 mentioned this pull request Sep 14, 2022
Closed
@tamalsaha
Copy link
Contributor

Could you please cut a release with the 1.25 deps?

@lucacome lucacome mentioned this pull request Sep 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@varshaprasad96 varshaprasad96 varshaprasad96 approved these changes

@camilamacedo86 camilamacedo86 camilamacedo86 approved these changes

@droot droot Awaiting requested review from droot

@mengqiy mengqiy Awaiting requested review from mengqiy

Assignees

@camilamacedo86 camilamacedo86

@varshaprasad96 varshaprasad96

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Jefftree @k8s-triage-robot @camilamacedo86 @k8s-ci-robot @tamalsaha @varshaprasad96