Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Better UserAgent for leader-election client #981

Merged
merged 2 commits into from
Jul 10, 2020
Merged

🐛 Better UserAgent for leader-election client #981

merged 2 commits into from
Jul 10, 2020

Conversation

jdef
Copy link
Contributor

@jdef jdef commented Jun 5, 2020

suffix the leader-election client with /leader-election for better auditing

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 5, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @jdef. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

Welcome @jdef!

It looks like this is your first PR to kubernetes-sigs/controller-runtime 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/controller-runtime has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 5, 2020
@jdef
Copy link
Contributor Author

jdef commented Jun 5, 2020

/assign @joelanford

@alenkacz
Copy link
Contributor

alenkacz commented Jun 6, 2020

/lgtm

👋 High James :) Long time no see...

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 6, 2020
@jdef
Copy link
Contributor Author

jdef commented Jun 6, 2020

/lgtm

👋 High James :) Long time no see...

Hi, Alena! Hope you're doing well.

@jdef
Copy link
Contributor Author

jdef commented Jun 8, 2020

@alenkacz mind giving this an "ok to test" label?

@pigletfly
Copy link
Contributor

/ok-to-test

@k8s-ci-robot
Copy link
Contributor

@pigletfly: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jdef
Copy link
Contributor Author

jdef commented Jun 12, 2020

can someone add the "ok-to-test" label here, please?

@alenkacz
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 13, 2020
@jdef
Copy link
Contributor Author

jdef commented Jun 17, 2020

thanks, can someone please /approve this?

@alvaroaleman
Copy link
Member

/assign @vincepri

@vincepri
Copy link
Member

Code changes look good, mind squashing commits before we merge it?

@alvaroaleman
Copy link
Member

/label tide/merge-method-squash
Let github do the squashing

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Jul 10, 2020
vincepri
vincepri approved these changes Jul 10, 2020
View reviewed changes
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jdef, vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 10, 2020
@k8s-ci-robot k8s-ci-robot merged commit 5676182 into kubernetes-sigs:master Jul 10, 2020
vincepri pushed a commit to vincepri/controller-runtime that referenced this pull request Jul 22, 2020
@jdef @vincepri
🐛 Better UserAgent for leader-election client (kubernetes-sigs#981)
1ab82e9 
* better UserAgent for leader-election client

* fixup
vincepri pushed a commit to vincepri/controller-runtime that referenced this pull request Jul 22, 2020
@jdef @vincepri
🐛 Better UserAgent for leader-election client (kubernetes-sigs#981)
29ffd05 
* better UserAgent for leader-election client

* fixup
vincepri pushed a commit to vincepri/controller-runtime that referenced this pull request Jul 22, 2020
@jdef @vincepri
🐛 Better UserAgent for leader-election client (kubernetes-sigs#981)
39554bd 
* better UserAgent for leader-election client

* fixup
kevindelgado pushed a commit to kevindelgado/controller-runtime that referenced this pull request Sep 15, 2020
@jdef @kevindelgado
🐛 Better UserAgent for leader-election client (kubernetes-sigs#981)
a45c56f 
* better UserAgent for leader-election client

* fixup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincepri vincepri vincepri approved these changes

@alenkacz alenkacz Awaiting requested review from alenkacz

@DirectXMan12 DirectXMan12 Awaiting requested review from DirectXMan12

Assignees

@alenkacz alenkacz

@joelanford joelanford

@vincepri vincepri

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jdef @k8s-ci-robot @alenkacz @pigletfly @alvaroaleman @vincepri @joelanford