🏃♂️ add apidiff.sh #905
Merged
🏃♂️ add apidiff.sh #905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/assign @vincepri @joelanford |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexeldeib, vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add apidiff check on PR presubmits
@joelanford @vincepri do you think this is better off added to verify.sh in the existing jobs, or added as a separate script + presubmit like in cluster-api?
If we do it separately we could make it optional to account for the occasional breaks. Maintainers can manually merge on breaks anyway, which probably makes more sense than Prow auto-merging api breaks, so I'm okay leaving it here. WDYT?
Also since the presubmits already set up the correct refs, I think this should "just work" in terms of checking the commits we care about for older releases and master too?