-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⚠️ Update dependencies to k8s 1.17 #795
Conversation
1. kubernetes/client-go@fed41f5 This client-go commit is a refactoring that changes how the client and server negotiate the content type and decoder. As a result of this refactoring, controller-runtime's recorder_test has a broken assumption for causing an error creating the client. Therefore, this commit updates the recorder test to use an invalid host, which causes the client to fail in the same way as before, ensuring the test continues to pass. 2. kubernetes/client-go@ba49d2a This client-go commit is a breaking change to resourcelock.Interface. As a result of this change, controller-runtime's fake ResourceLock implementation needed to be updated to account for the interface change. Signed-off-by: Vince Prignano <vincepri@vmware.com>
Made sure to use @joelanford older commits for attribution, this should be good to go! /assign @DirectXMan12 @gerred |
/retest |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: DirectXMan12, vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
From the older PR: #754