-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ add GetConfigWithContext to retrieve a config with a specific context #489
✨ add GetConfigWithContext to retrieve a config with a specific context #489
Conversation
Welcome @sbueringer! |
/assign @DirectXMan12 |
@DirectXMan12 How do I fix the following build error? Couldn't find anything in the docs.
EDIT: okay I fixed it by adding the line manually to Gopkg.locks then I tried hack/check-everything.sh and it worked (but it also lead to changes in go.mod & go.sum which I didn't checked in). What would have been the right/automated way to fix it? |
|
Can you add a bit more details to the PR message beyond just the fixes? It's useful when going through with |
otherwise looks reasonable |
I added some more text here in the PR. The commit message itself already is: EDIT: I squashed the commit by myself, but just out of curiosity for the next time. Is it done automatically? |
80beb89
to
3b365c5
Compare
3b365c5
to
8e131cc
Compare
We don't automatically squash, no. It's up to the submitter to produce a chain of logical commits (we don't enforce 1 commit per PR -- we just prefer that each commit stands on its own). |
/lgtm thanks! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: DirectXMan12, sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR adds a new function to the config package. Before it was only possible to retrieve the current context of a kubeconfig file via
GetConfig
. Now there's an additionalGetConfigWithContext
where a specific context can be retrieved.The advantage is when developing locally (run controllers via IDE) with a specified context, the controller is not dependent on whatever the current context is of the used kubeconfig file.
Fixes #479