✨ support custom negotiated serializer 🐛 #382
Conversation
|
I assume, since I cut from broken master, the CI test are failing for the same reason here. |
|
It's a flake. I think we may need to bump the version of the kubernetes binaries used in our tests. |
|
Seems fairly reasonable, but the godocs need an update to mention this. Otherwise LGTM. |
|
@DirectXMan12 I'm happy to update the GoDocs. In which package did you have in mind? I call |
|
The GoDocs on RESTClientForGVK should mention this. |
ah, ok. |
The Kubernetes client allows for users to configure a serializer which is used to encode and decode resources exchanged with the Kubernetes API server. This changeset modifies the controller-runtime client to only set the default serializer if the NegotiatedSerializer option is nil. Signed-off-by: Terin Stock <terin@cloudflare.com>
7f0fb8f to
7ba0932
Compare
|
@DirectXMan12 I added a note, I'm happy to make changes if you have a better way to word it. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: DirectXMan12, terinjokes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
version 1.0.0 is no longer usable Related: #382
The Kubernetes client allows for users to configure a serializer which
is used to encode and decode resources exchanged with the Kubernetes API
server.
This changeset modifies the controller-runtime client to only set the
default serializer if the NegotiatedSerializer option is nil.
Signed-off-by: Terin Stock terin@cloudflare.com