✨ update kubernetes 1.13 to the latest patch release #349
Conversation
|
@detiber Can we push this in pretty please :) ? |
|
@tariq1890 The PR title should be prefixed with ✨ given that this is a backward compatible change. /assign @DirectXMan12 |
|
/assign @fanzhangio |
|
/assign @k8s-ci-robot |
|
Can you please add a PR description motivating this change -- it's useful for looking back at the merge history to see why something was particularly relevant. |
|
(even just something like "1.13.4 includes a fix for bug XYZ that affects CR users when they do foo") |
|
@DirectXMan12 I've mentioned the reason. |
|
Any updates on this? |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: DirectXMan12, tariq1890 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
It is in the best interests of any k8s API consumer that we always vendor in the latest patch release of a minor version.
As controller-runtime acts as the primary source of k8s-dependencies for cluster-API and its providers, best practices mandate that we update the versions at the root so that they percolate down to the Cluster API providers. If this change is not accepted, we would be forced to use override deps.