🐛 fake client: preserve TypeMeta during List call with UnstructuredList #3074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d8898a1 to
8ac42bc
Compare
|
/assign @vincepri @alvaroaleman |
Signed-off-by: Stefan Büringer buringerst@vmware.com
8ac42bc to
3b23354
Compare
|
/hold testing with CAPI |
|
/hold cancel all good |
alvaroaleman
approved these changes
Jan 16, 2025
|
LGTM label has been added. Git tree hash: c5611d73ec60a396f8135461ec0b480e7b80eaed
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Stefan Büringer buringerst@vmware.com
Follow-up to #3022
After 3022 the fake client List call was dropping TypeMeta (apiVersion + kind)