-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Rev dependencies to k8s 1.13 #279
Conversation
@vincepri heads up |
/assign @DirectXMan12 |
To check that this doesn't change the signature of our public interface,use #229. I need to fix it up to get it mergable, but you can run it using the code in the PR in the mean time. Just generate "before" and "after" outputs, and diff them to make sure things haven't changed. |
@DirectXMan12 running the external objects tooling returns the following diff: diff ~/tmp/cr-external-objects.before ~/tmp/cr-external-objects.after
< "k8s.io/client-go/rest".Config -- struct{Host string; APIPath string; k8s.io/client-go/rest.ContentConfig; Username string; Password string; BearerToken string; Impersonate k8s.io/client-go/rest.ImpersonationConfig; AuthProvider *k8s.io/client-go/tools/clientcmd/api.AuthProviderConfig; AuthConfigPersister k8s.io/client-go/rest.AuthProviderConfigPersister; ExecProvider *k8s.io/client-go/tools/clientcmd/api.ExecConfig; k8s.io/client-go/rest.TLSClientConfig; UserAgent string; Transport net/http.RoundTripper; WrapTransport func(rt net/http.RoundTripper) net/http.RoundTripper; QPS float32; Burst int; RateLimiter k8s.io/client-go/util/flowcontrol.RateLimiter; Timeout time.Duration; Dial func(ctx context.Context, network string, address string) (net.Conn, error)}
---
> "k8s.io/client-go/rest".Config -- struct{Host string; APIPath string; k8s.io/client-go/rest.ContentConfig; Username string; Password string; BearerToken string; BearerTokenFile string; Impersonate k8s.io/client-go/rest.ImpersonationConfig; AuthProvider *k8s.io/client-go/tools/clientcmd/api.AuthProviderConfig; AuthConfigPersister k8s.io/client-go/rest.AuthProviderConfigPersister; ExecProvider *k8s.io/client-go/tools/clientcmd/api.ExecConfig; k8s.io/client-go/rest.TLSClientConfig; UserAgent string; Transport net/http.RoundTripper; WrapTransport func(rt net/http.RoundTripper) net/http.RoundTripper; QPS float32; Burst int; RateLimiter k8s.io/client-go/util/flowcontrol.RateLimiter; Timeout time.Duration; Dial func(ctxcontext.Context, network string, address string) (net.Conn, error)} There is a single (additive) change to the client-go/rest.Config object that adds |
The diff above seems to be fine. |
/lgtm Thanks for your work! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: detiber, DirectXMan12 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
remove cert generator and add redirection
Updates Kubernetes dependencies to v1.13, required for #275