🐛 Runnable group should check if stopped before enqueueing #2757
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Vince Prignano <vincepri@redhat.com>
| <-time.After(1 * time.Millisecond) | ||
| ctx, cancel := context.WithCancel(context.Background()) | ||
| cancel() | ||
| rg.StopAndWait(ctx) |
There was a problem hiding this comment.
There is no guarantee that this is called after rg.Start, right? Is this intended?
If I see correctly it doesn't really matter which one is called first as StopAndWait calls Start internally and Start is using once? (just to confirm)
There was a problem hiding this comment.
That's correct, it doesn't really matter because they can both run at the same time, the waitgroup triggers. It's a best effort to try to reproduce the failure consistently, but not a guaranteed one. Although on my mac, it did trigger the race pretty consistently
|
/lgtm |
|
LGTM label has been added. Git tree hash: 4981ed4ab135ad5f4474ff1eb6d05fc88508aedb
|
|
Will we get this cherry picked to |
|
/cherry-pick release-0.17 |
|
@sbueringer: new pull request created: #2761 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fixes #2756