🌱 Update golanci-lint to v1.57.2 #2751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alvaroaleman
reviewed
Apr 2, 2024
| @@ -401,23 +399,17 @@ func (cm *controllerManager) Start(ctx context.Context) (err error) { | |||
| // between conversion webhooks and the cache sync (usually initial list) which causes the webhooks | |||
| // to never start because no cache can be populated. | |||
| if err := cm.runnables.Webhooks.Start(cm.internalCtx); err != nil { | |||
| if err != nil { | |||
pkg/manager/runnable_group.go
Outdated
| @@ -77,7 +77,7 @@ func (r *runnables) Add(fn Runnable) error { | |||
| // | |||
| // Runnables can be added to a group after the group has started | |||
| // but not after it's stopped or while shutting down. | |||
| type runnableGroup struct { | |||
| type runnableGroup struct { //nolint:fieldalignment | |||
There was a problem hiding this comment.
Is that nolint diretive still needed now that you have disabled this? And can we enable nolintlint?
tools/setup-envtest/store/store.go
Outdated
| @@ -182,7 +182,7 @@ func (s *Store) Add(ctx context.Context, item Item, contents io.Reader) (resErr | |||
| return err | |||
| } | |||
| } | |||
| if err != nil && !errors.Is(err, io.EOF) { | |||
| if !errors.Is(err, io.EOF) { | |||
There was a problem hiding this comment.
Is it correct to error out if err is nil?
3b56d26 to
37ee9f6
Compare
Signed-off-by: Vince Prignano <vincepri@redhat.com>
37ee9f6 to
7b4325d
Compare
alvaroaleman
approved these changes
Apr 3, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.