Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Add ListenerConfig for metrics server options #2519

Merged
merged 6 commits into from
Jan 31, 2024
Merged

✨ Add ListenerConfig for metrics server options #2519

merged 6 commits into from
Jan 31, 2024

Conversation

tomelliot16
Copy link
Contributor

The reason for this change is having the ability to set a custom ListenConfig on the metric server listener.

The reason I need (my company needs) it is that it will allow us to set unix.SO_REUSEPORT flag which works around an edge case when a port is ever leaked and you are using the host network for your controller.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Sep 27, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot
Copy link
Contributor

Welcome @tomelliot16!

It looks like this is your first PR to kubernetes-sigs/controller-runtime 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/controller-runtime has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 27, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @tomelliot16. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Sep 27, 2023
@tomelliot16 tomelliot16 changed the title ✨ Add ListenerConfig for metrics service options ✨ Add ListenerConfig for metrics server options Sep 27, 2023
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Sep 27, 2023
troy0820
troy0820 suggested changes Sep 28, 2023
View reviewed changes
Copy link
Member

@troy0820 troy0820 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should work if SecureServing=true with the feedback presented as well as guarding against the options if they do not exist.

@troy0820
Copy link
Member

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 28, 2023
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 9, 2023
vincepri
vincepri reviewed Oct 19, 2023
View reviewed changes
pkg/metrics/server/server.go Outdated Show resolved Hide resolved
pkg/metrics/server/server.go Outdated Show resolved Hide resolved
@sbueringer
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 19, 2023
@k8s-ci-robot k8s-ci-robot removed the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 19, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 19, 2023
@tomelliot16
Copy link
Contributor Author

tomelliot16 commented Oct 31, 2023 •
edited
Loading

@vincepri Any idea if this can be approved and merged? Is it missing anything?

edit: NVM I just read the above will assign the correct person.

@tomelliot16
Copy link
Contributor Author

/assign sbueringer

@tomelliot16
Copy link
Contributor Author

@sbueringer Did I miss anything in the process or anything I can do to help?

@tomelliot16
Copy link
Contributor Author

Any update here?

@alvaroaleman alvaroaleman added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Dec 23, 2023
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 5, 2024
@sbueringer
Copy link
Member

@tomelliot16 Do you have time to address the remaining finding?

(if it gets fixed quickly we can include it into v0.17)

@sbueringer sbueringer added this to the v0.17.x milestone Jan 9, 2024
@tomelliot16
Copy link
Contributor Author

@sbueringer just saw this going to address comments.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 16, 2024
@tomelliot16
Copy link
Contributor Author

@sbueringer I returned the error but didn't know if we wanted to make a special error wrapping with some context.

@sbueringer
Copy link
Member

@sbueringer I returned the error but didn't know if we wanted to make a special error wrapping with some context.

It's fine as is. One last nit

@sbueringer
Copy link
Member

/ok-to-test

@tomelliot16 @sbueringer
Update pkg/metrics/server/server.go
11fe5c6 
Co-authored-by: Stefan Büringer <4662360+sbueringer@users.noreply.github.com>
@troy0820
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 22, 2024
@sbueringer
Copy link
Member

Thx!

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer, tomelliot16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 31, 2024
@k8s-ci-robot k8s-ci-robot merged commit 73519a9 into kubernetes-sigs:main Jan 31, 2024
9 checks passed
@troy0820
Copy link
Member

@sbueringer this was slated for v0.17, did we want to cherry pick to that?

@sbueringer
Copy link
Member

sbueringer commented Feb 1, 2024 •
edited
Loading

@sbueringer this was slated for v0.17, did we want to cherry pick to that?

Good catch. No strong opinion from my side either way. I mostly flagged it for v0.17 because at some point I thought it will make it into the release and I wanted to track it as part of the milestone

(flagged this PR now as v0.18 as this PR won't make it there, cherry-pick PR would then be flagged as v0.17)

@sbueringer sbueringer modified the milestones: v0.17.x, v0.18.x Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@troy0820 troy0820 troy0820 requested changes

@sbueringer sbueringer sbueringer left review comments

@vincepri vincepri vincepri left review comments

@FillZpp FillZpp Awaiting requested review from FillZpp

@varshaprasad96 varshaprasad96 Awaiting requested review from varshaprasad96

@alvaroaleman alvaroaleman Awaiting requested review from alvaroaleman

Assignees

@sbueringer sbueringer

@troy0820 troy0820

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
v0.18.x
Development

Successfully merging this pull request may close these issues.
6 participants
@tomelliot16 @k8s-ci-robot @troy0820 @sbueringer @vincepri @alvaroaleman