-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Fix reconcile duration metric #248
🐛 Fix reconcile duration metric #248
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
The previous implementation lacked delayed execution, leading to end - now not reflecting the duration of the reconcile request handling.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! Thanks for the PR.
@j-vizcaino you will need to sign the CLA |
Yes, sorry about this. Initial attempt failed l. Will fix that tonight.
…On Wed, Dec 12, 2018, 20:05 Sunil Arora ***@***.***> wrote:
@j-vizcaino <https://github.com/j-vizcaino> you will need to sign the CLA
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#248 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AEfKlWRVRmjQ29RqcLxfig2trGMOxLKCks5u4VN7gaJpZM4ZQFrC>
.
|
Signed the CLA. This should be good now. |
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: j-vizcaino The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Link project deps from hack/imports.go
The previous implementation lacked delayed execution, leading to
end - now
not reflecting the duration of the reconcile request handling.