-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Update to Kubernetes 1.12.3 #230
✨ Update to Kubernetes 1.12.3 #230
Conversation
Wait - I just noticed there are no differences in vendored files... so what to do here? @DirectXMan12? It's a shame we have to reference a specific tagged version of Kubernetes (e.g. /assign @DirectXMan12 |
@DirectXMan12 @mengqiy Any time to review? |
We generally pin all the k8s dep to a released version instead of a branch. We upgrade the k8s dep about once per quarter, so these 2 approaches don't have much differences for us. No breaking changes |
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: jimmidyson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
OK thanks for explaining @mengqiy. This PR follows that convention and pins to released versions. Would be good to merge :) |
I want to update controller-tools but need a tag to reference there. Can someone do that please? |
There are some changes we want to make about the metric support before tagging a new release. |
✨ Update to Kubernetes 1.12.3
As requested in #221 (comment)
This has no breaking changes, only changes to dependencies and internal changes to work with the new version.