Refactor metrics tests #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/assign @DirectXMan12 |
droot
approved these changes
Nov 6, 2018
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: DirectXMan12, JoelSpeed The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
justinsb
pushed a commit
to justinsb/controller-runtime
that referenced
this pull request
Dec 7, 2018
Refactor metrics tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #199
I've had a look at the tests for the metrics and refactored them a bit, using
Reset()instead of manually assigning the metrics seems to be a better approach and then making sure the values are reset before starting the rest of the testI've also changed the check for the histogram test, it seemingly was reconciling twice during the test so sample count was 2 every so often. I've made it so we check that at least 1 sample is counted to fix the flake, not sure there's a better way to fix it than that
I ran the tests with
ginkgo -untilItFailsover 50 times before I gave upCC @droot @DirectXMan12