Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🏃 hack/setup-envtest.sh: follow-up from #1092 #1097

Merged
merged 1 commit into from
Aug 4, 2020
Merged

🏃 hack/setup-envtest.sh: follow-up from #1092 #1097

merged 1 commit into from
Aug 4, 2020

Conversation

joelanford
Copy link
Member

This follows up #1092 to address some of the comments and suggestions.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 3, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: joelanford

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 3, 2020
@joelanford
Copy link
Member Author

/cc @camilamacedo86 @vincepri @alvaroaleman @DirectXMan12

@vincepri Just saw your follow-up about copying the header text function. I'll update this PR now.

@vincepri
Copy link
Member

vincepri commented Aug 3, 2020

Thanks for following up! The changes look great, will tag it once the header text is in

@joelanford
Copy link
Member Author

@vincepri WDYT about removing set -o nounset from setup-envtest.sh?

I was testing it out by running source ./hack/setup-envtest.sh; echo $KUBEBUILDER_ASSETS and expecting to see it return an empty string before calling setup_envtest_env.

Instead, my terminal exited because $KUBEBUILDER_ASSETS was not set yet.

We could add this to hack/check-everything.sh since we don't expect people to be source-ing that script.

@vincepri
Copy link
Member

vincepri commented Aug 3, 2020

Got it, I don't have time to try today, but I didn't get the same error in a similar cluster api script

vincepri
vincepri reviewed Aug 3, 2020
View reviewed changes
hack/setup-envtest.sh
# Setup env vars
KUBEBUILDER_ASSETS=${KUBEBUILDER_ASSETS:-""}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can probably remove this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually had to keep these if we want to use set -o nounset in ./hack/check-everything.sh

vincepri
vincepri reviewed Aug 3, 2020
View reviewed changes
hack/setup-envtest.sh
function fetch_envtest_tools {
SKIP_FETCH_TOOLS=${SKIP_FETCH_TOOLS:-""}
if [ -n "$SKIP_FETCH_TOOLS" ]; then
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can probably remove this?

@vincepri
Copy link
Member

vincepri commented Aug 4, 2020

/test pull-controller-runtime-test-master

vincepri
vincepri approved these changes Aug 4, 2020
View reviewed changes
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 4, 2020
@vincepri
Copy link
Member

vincepri commented Aug 4, 2020

/milestone v0.6.x

@k8s-ci-robot k8s-ci-robot added this to the v0.6.x milestone Aug 4, 2020
@vincepri
Copy link
Member

vincepri commented Aug 4, 2020

/retest

@k8s-ci-robot k8s-ci-robot merged commit 6b734aa into kubernetes-sigs:master Aug 4, 2020
@joelanford joelanford deleted the setup-envtest-2 branch August 4, 2020 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincepri vincepri vincepri approved these changes

@DirectXMan12 DirectXMan12 Awaiting requested review from DirectXMan12

@mengqiy mengqiy Awaiting requested review from mengqiy

@alvaroaleman alvaroaleman Awaiting requested review from alvaroaleman

@camilamacedo86 camilamacedo86 Awaiting requested review from camilamacedo86

Assignees

@vincepri vincepri

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v0.6.x
Development

Successfully merging this pull request may close these issues.
3 participants
@joelanford @k8s-ci-robot @vincepri