"non-exact field matches are not supported by the cache" when using fieldSelector with not exact fields #612

sarjeet2013 · 2019-09-24T19:05:35Z

I am getting the following error when trying to get list of pods with their state filetered with fieldSelector.

"error":"non-exact field matches are not supported by the cache"

Here is the sample code:

fieldSelector, err := fields.ParseSelector("spec.nodeName=" + nodeName + ",status.phase!=" + string(corev1.PodSucceeded) + ",status.phase!=" + string(corev1.PodFailed))
activePodsList := &corev1.PodList{}
listOptions := &client.ListOptions{FieldSelector: fieldSelector}
if err := r.List(context.TODO(), listOptions, activePodsList); err != nil {
  return reconcile.Result{}, err
}

This look like a current limitation and not supported. See https://github.com/kubernetes-sigs/controller-runtime/blob/master/pkg/cache/internal/cache_reader.go#L99

The text was updated successfully, but these errors were encountered:

DirectXMan12 · 2019-09-30T22:03:47Z

it's unclear to me how we'd support this w/o becoming fairly complicated.

/kind feature
/priority backlog

lawrencegripper · 2019-11-18T18:07:11Z

In case anyone else lands here from KubeBuilder and wants an workaround I was able to create a client instance without caching using the mgr in the autogen'd main.go like this:

directClient, err := client.New(mgr.GetConfig(), client.Options{Scheme: mgr.GetScheme(), Mapper: mgr.GetRESTMapper()})
if err != nil {
	panic(err)
}

shawn-hurley · 2019-12-15T05:59:48Z

Another option is to use the mgr.GetReader() which will allow you to hit the API server directly with a reader interface.

📖 Elaborate on the design pricipals of KB

vincepri · 2020-02-21T17:24:37Z

/kind design
/priority awaiting-more-evidence

maplain · 2020-02-29T02:48:30Z

figured out another approach:

use client.MatchingFields;
customize the IndexField to make it return a value that is parameterized by multiple fields

eg:

m := client.MatchingFields{
  key: getValue(obj)
}

mgr.GetFieldIndexer().IndexField(obj, key, func(xx) []string{
   return []string{getValue(obj)}
})

func getValue(obj) string {
   return obj.Spec.A + "," + obj.Spec.B + "," + obj.Spec.C
}

Client.List(xx, xxx, m)

fejta-bot · 2020-05-29T03:30:29Z

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

fejta-bot · 2020-06-28T04:11:30Z

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

fejta-bot · 2020-07-28T04:52:47Z

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

k8s-ci-robot · 2020-07-28T04:52:53Z

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Walk the returned list to verify the binding matches the expect type and name. In order to use the MatchingFields with the caching Client, an IndexField first needs to be created. However, we need to match multiple fields, but controller-runtime only supports one field easily: kubernetes-sigs/controller-runtime#612 The expected number of bindings per namespace isn't very many, so it is unlikely there is much to gain with an index. The fake client doesn't support MatchingFields, and we didn't have a negative test so this otherwise went unnoticed until the FSS was flipped.

kscharm · 2021-09-01T16:06:04Z

I am getting the following error when trying to get list of pods with their state filetered with fieldSelector.

"error":"non-exact field matches are not supported by the cache"

Here is the sample code:
fieldSelector, err := fields.ParseSelector("spec.nodeName=" + nodeName + ",status.phase!=" + string(corev1.PodSucceeded) + ",status.phase!=" + string(corev1.PodFailed))
activePodsList := &corev1.PodList{}
listOptions := &client.ListOptions{FieldSelector: fieldSelector}
if err := r.List(context.TODO(), listOptions, activePodsList); err != nil {
  return reconcile.Result{}, err
}
This look like a current limitation and not supported. See https://github.com/kubernetes-sigs/controller-runtime/blob/master/pkg/cache/internal/cache_reader.go#L99

@sarjeet2013 I'm trying to do the same thing you are here (same field selector). Were you able to find a workaround? I have tried the suggestions in the comments, but I think I am going to have to directly hit the API to get this to work. It seems that fields selectors with multiple fields simply do not work. I have added the proper field indexers to my manager:

nodeNameIndexFunc := func(obj client.Object) []string {
	return []string{obj.(*v1.Pod).Spec.NodeName}
}

if err = mgr.GetFieldIndexer().IndexField(context.Background(), &v1.Pod{}, "spec.nodeName", nodeNameIndexFunc); err != nil {
	glog.Fatalf("unable to set up field indexer for spec.nodeName: %v", err)
}

phaseIndexFunc := func(obj client.Object) []string {
	return []string{string(obj.(*v1.Pod).Status.Phase)}
}

if err = mgr.GetFieldIndexer().IndexField(context.Background(), &v1.Pod{}, "status.phase", phaseIndexFunc); err != nil {
	glog.Fatalf("unable to set up field indexer for status.phase: %v", err)
}

And I still face the same error as you: non-exact field matches are not supported by the cache

kscharm · 2021-09-01T16:09:09Z

/reopen

k8s-ci-robot · 2021-09-01T16:09:17Z

@kscharm: You can't reopen an issue/PR unless you authored it or you are a collaborator.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

JohnNiang · 2021-09-08T04:50:17Z

Exactly caused by Line#192:

controller-runtime/pkg/cache/internal/cache_reader.go

Lines 190 to 200 in 386c2b5

    
           func requiresExactMatch(sel fields.Selector) (field, val string, required bool) { 
        
           	reqs := sel.Requirements() 
        
           	if len(reqs) != 1 { 
        
           		return "", "", false 
        
           	} 
        
           	req := reqs[0] 
        
           	if req.Operator != selection.Equals && req.Operator != selection.DoubleEquals { 
        
           		return "", "", false 
        
           	} 
        
           	return req.Field, req.Value, true 
        
           }

And a TODO is here Line#117:

controller-runtime/pkg/cache/internal/cache_reader.go

Lines 108 to 126 in 386c2b5

    
           func (c *CacheReader) List(_ context.Context, out client.ObjectList, opts ...client.ListOption) error { 
        
           	var objs []interface{} 
        
           	var err error 
        
           	listOpts := client.ListOptions{} 
        
           	listOpts.ApplyOptions(opts) 
        
           	switch { 
        
           	case listOpts.FieldSelector != nil: 
        
           		// TODO(directxman12): support more complicated field selectors by 
        
           		// combining multiple indices, GetIndexers, etc 
        
           		field, val, requiresExact := requiresExactMatch(listOpts.FieldSelector) 
        
           		if !requiresExact { 
        
           			return fmt.Errorf("non-exact field matches are not supported by the cache") 
        
           		} 
        
           		// list all objects by the field selector.  If this is namespaced and we have one, ask for the 
        
           		// namespaced index key.  Otherwise, ask for the non-namespaced variant by using the fake "all namespaces" 
        
           		// namespace. 
        
           		objs, err = c.indexer.ByIndex(FieldIndexName(field), KeyToNamespacedKey(listOpts.Namespace, val))

Walk the returned list to verify the binding matches the expect type and name. In order to use the MatchingFields with the caching Client, an IndexField first needs to be created. However, we need to match multiple fields, but controller-runtime only supports one field easily: kubernetes-sigs/controller-runtime#612 The expected number of bindings per namespace isn't very many, so it is unlikely there is much to gain with an index. The fake client doesn't support MatchingFields, and we didn't have a negative test so this otherwise went unnoticed until the FSS was flipped.

k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence. labels Sep 30, 2019

DirectXMan12 pushed a commit that referenced this issue Jan 31, 2020

Merge pull request #612 from DirectXMan12/docs/principals

affc14a

📖 Elaborate on the design pricipals of KB

k8s-ci-robot added kind/design Categorizes issue or PR as related to design. priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done. labels Feb 21, 2020

vincepri added this to the Next milestone Feb 21, 2020

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 29, 2020

k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jun 28, 2020

k8s-ci-robot closed this as completed Jul 28, 2020

MaxFedotov mentioned this issue Aug 28, 2020

Support Groups as Subject Kind for Tenant Namespace RoleBindings created by Capsule projectcapsule/capsule#71

Merged

halfcrazy mentioned this issue Sep 25, 2023

✨client: client.MatchingFields support multiple indexes #2511

Closed

halfcrazy mentioned this issue Sep 25, 2023

✨client: client.MatchingFields support multiple indexes #2512

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

"non-exact field matches are not supported by the cache" when using fieldSelector with not exact fields #612

"non-exact field matches are not supported by the cache" when using fieldSelector with not exact fields #612

sarjeet2013 commented Sep 24, 2019

DirectXMan12 commented Sep 30, 2019

lawrencegripper commented Nov 18, 2019

shawn-hurley commented Dec 15, 2019

vincepri commented Feb 21, 2020

maplain commented Feb 29, 2020 •

edited

Loading

fejta-bot commented May 29, 2020

fejta-bot commented Jun 28, 2020

fejta-bot commented Jul 28, 2020

k8s-ci-robot commented Jul 28, 2020

kscharm commented Sep 1, 2021 •

edited

Loading

kscharm commented Sep 1, 2021

k8s-ci-robot commented Sep 1, 2021

JohnNiang commented Sep 8, 2021 •

edited

Loading

"non-exact field matches are not supported by the cache" when using fieldSelector with not exact fields #612

"non-exact field matches are not supported by the cache" when using fieldSelector with not exact fields #612

Comments

sarjeet2013 commented Sep 24, 2019

DirectXMan12 commented Sep 30, 2019

lawrencegripper commented Nov 18, 2019

shawn-hurley commented Dec 15, 2019

vincepri commented Feb 21, 2020

maplain commented Feb 29, 2020 • edited Loading

fejta-bot commented May 29, 2020

fejta-bot commented Jun 28, 2020

fejta-bot commented Jul 28, 2020

k8s-ci-robot commented Jul 28, 2020

kscharm commented Sep 1, 2021 • edited Loading

kscharm commented Sep 1, 2021

k8s-ci-robot commented Sep 1, 2021

JohnNiang commented Sep 8, 2021 • edited Loading

maplain commented Feb 29, 2020 •

edited

Loading

kscharm commented Sep 1, 2021 •

edited

Loading

JohnNiang commented Sep 8, 2021 •

edited

Loading