-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Fix DockerMachine panic #9673
🐛 Fix DockerMachine panic #9673
Conversation
Welcome @makhov! |
Hi @makhov. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
/area provider/infrastructure-docker
Q: Can a dockermachine possibly be created in a topology managed cluster where the infrastructureRef
isn't set? That's surprising to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change looks good to me - just one Q
/lgtm
LGTM label has been added. Git tree hash: 5f2b1b16974fa454851ce33dd8ffd445c2ad8990
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/cherry-pick release-1.4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/cherry-pick release-1.5
Yes. I bumped into this when I was working on adding ClusterClass support to the k0smotron Cluster API provider, and had some of the resources misconfigured. CAPI controller manager wasn't able to add infrastructureRef to the Cluster object, which caused panic. |
Hmm - I guess the topology controller does go ahead and create the MDs etc. even if the Cluster doesn't have an |
That's fine, I think, the problem here is the panic. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-1.5 |
/cherry-pick release-1.4 |
@killianmuldoon: new pull request created: #9689 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@killianmuldoon: new pull request created: #9690 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
The PR fixes panic in the
DockerMachineReconciler
in casecluster.Spec.InfrastructureRef
doesn't yet exist.When using
ClusterClass
, theCluster
can contain justspec.topology
at the beginning, other fields will be added later by the controller manager.(the trace below is from the v1.5.3, but the bug still exists in the main branch)