Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📖 add documentation about namingStrategy in ClusterClasses #9433

Merged
merged 1 commit into from
Sep 14, 2023
Merged

📖 add documentation about namingStrategy in ClusterClasses #9433

merged 1 commit into from
Sep 14, 2023

Conversation

chrischdi
Copy link
Member

What this PR does / why we need it:

Follow-up to #9340

Adds a section in the book about naming strategy in clusterclasses.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

/area book

@k8s-ci-robot
Copy link
Contributor

@chrischdi: The label(s) area/book cannot be applied, because the repository doesn't have them.

In response to this:

What this PR does / why we need it:

Follow-up to #9340

Adds a section in the book about naming strategy in clusterclasses.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

/area book

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-area PR is missing an area label size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 14, 2023
@chrischdi
Copy link
Member Author

/assign @sbueringer @killianmuldoon

@chrischdi
Copy link
Member Author

/area docs

@k8s-ci-robot
Copy link
Contributor

@chrischdi: The label(s) area/docs cannot be applied, because the repository doesn't have them.

In response to this:

/area docs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@chrischdi
Copy link
Member Author

/area documentation

@k8s-ci-robot k8s-ci-robot added area/documentation Issues or PRs related to documentation and removed do-not-merge/needs-area PR is missing an area label labels Sep 14, 2023
killianmuldoon
killianmuldoon reviewed Sep 14, 2023
View reviewed changes
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - one nit / clarification.

@chrischdi chrischdi force-pushed the pr-topology-namingstrategy-docs branch from c988fd1 to 457692a Compare September 14, 2023 13:32
killianmuldoon
killianmuldoon reviewed Sep 14, 2023
View reviewed changes
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 14, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: eb7a1e05e95adc3d8a263bd9ac5054677edba75f

fabriziopandini
fabriziopandini reviewed Sep 14, 2023
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for writing this doc!
/lgtm

@killianmuldoon
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: killianmuldoon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 14, 2023
@k8s-ci-robot k8s-ci-robot merged commit c4e2d67 into kubernetes-sigs:main Sep 14, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.6 milestone Sep 14, 2023
@sbueringer
Copy link
Member

/cherry-pick release-1.5

for the book
(we also cherry-picked the feature)

@k8s-infra-cherrypick-robot
Copy link

@sbueringer: new pull request created: #9435

In response to this:

/cherry-pick release-1.5

for the book
(we also cherry-picked the feature)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Sep 14, 2023
Merged
@chrischdi chrischdi mentioned this pull request Sep 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabriziopandini fabriziopandini fabriziopandini left review comments

@killianmuldoon killianmuldoon killianmuldoon left review comments

@elmiko elmiko Awaiting requested review from elmiko

@jackfrancis jackfrancis Awaiting requested review from jackfrancis

Assignees

@sbueringer sbueringer

@fabriziopandini fabriziopandini

@killianmuldoon killianmuldoon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/documentation Issues or PRs related to documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.6
Development

Successfully merging this pull request may close these issues.
6 participants
@chrischdi @k8s-ci-robot @killianmuldoon @sbueringer @k8s-infra-cherrypick-robot @fabriziopandini