Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📖 book: Update versions doc adding Kubernetes 1.28 + prowjob documentation #9161

Merged
merged 1 commit into from
Aug 17, 2023
Merged

📖 book: Update versions doc adding Kubernetes 1.28 + prowjob documentation #9161

merged 1 commit into from
Aug 17, 2023

Conversation

chrischdi
Copy link
Member

What this PR does / why we need it:

Update book:

TODO

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Related to #8708

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 10, 2023
@chrischdi chrischdi marked this pull request as draft August 10, 2023 06:30
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 10, 2023
@chrischdi chrischdi mentioned this pull request Aug 10, 2023
Closed
13 tasks
@sbueringer
Copy link
Member

sbueringer commented Aug 14, 2023 •
edited
Loading

Btw I think /hold is enough you don't have to keep it in draft state. Makes it slightly clearer that the PR can already be reviewed

@chrischdi chrischdi marked this pull request as ready for review August 14, 2023 09:51
@chrischdi chrischdi force-pushed the pr-1-28-book-versions branch from d59c4f9 to ef98759 Compare August 16, 2023 08:54
@chrischdi
Copy link
Member Author

/hold

Waiting for

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 16, 2023
@chrischdi
Copy link
Member Author

/retitle 📖 book: Update versions doc adding Kubernetes 1.28 + prowjob documentation

@k8s-ci-robot k8s-ci-robot changed the title [WIP] 📖 book: Update versions doc adding Kubernetes 1.28 + prowjob documentation 📖 book: Update versions doc adding Kubernetes 1.28 + prowjob documentation Aug 16, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 16, 2023
@chrischdi chrischdi mentioned this pull request Aug 16, 2023
Merged
6 tasks
killianmuldoon
killianmuldoon reviewed Aug 16, 2023
View reviewed changes
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 16, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: c48f64f0e49d7812be526b6340afbe0da7e009bc

@killianmuldoon
Copy link
Contributor

/area documentation

@k8s-ci-robot k8s-ci-robot added the area/documentation Issues or PRs related to documentation label Aug 16, 2023
@sbueringer
Copy link
Member

Looks good!

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 16, 2023
furkatgofurov7
furkatgofurov7 reviewed Aug 17, 2023
View reviewed changes
Copy link
Member

@furkatgofurov7 furkatgofurov7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sbueringer
Copy link
Member

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 17, 2023
@k8s-ci-robot k8s-ci-robot merged commit 1632b9e into kubernetes-sigs:main Aug 17, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.6 milestone Aug 17, 2023
@chrischdi chrischdi mentioned this pull request Aug 17, 2023
Merged
@killianmuldoon killianmuldoon mentioned this pull request Oct 19, 2023
Closed
14 tasks
@sbueringer sbueringer mentioned this pull request Jan 19, 2024
Closed
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbueringer sbueringer sbueringer left review comments

@furkatgofurov7 furkatgofurov7 furkatgofurov7 left review comments

@killianmuldoon killianmuldoon killianmuldoon left review comments

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

@stmcginnis stmcginnis Awaiting requested review from stmcginnis

@elmiko elmiko Awaiting requested review from elmiko

@jackfrancis jackfrancis Awaiting requested review from jackfrancis

Assignees

@furkatgofurov7 furkatgofurov7

@killianmuldoon killianmuldoon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/documentation Issues or PRs related to documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.6
Development

Successfully merging this pull request may close these issues.
5 participants
@chrischdi @sbueringer @k8s-ci-robot @killianmuldoon @furkatgofurov7