Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Add more reviewers and maintainers #7996

Merged
merged 1 commit into from
Feb 1, 2023
Merged

✨ Add more reviewers and maintainers #7996

merged 1 commit into from
Feb 1, 2023

Conversation

fabriziopandini
Copy link
Member

What this PR does / why we need it:
The Cluster API community is awesome! Many folks answered the call for action about new maintainers and reviewers!

Kudos and a huge thank you to:

  • @killianmuldoon (stepping up as a top-level maintainer 👏)
  • @ykakarap (stepping up as a top-level reviewer and clusterctl maintainer 👏)
  • @jackfrancis (stepping in as a top-level reviewer 👏)
  • @richardcase (stepping in as a top-level reviewer 👏)
  • @oscr (stepping up as a doc maintainer 👏)
  • @chrischdi (stepping in as a reviewer for topology controller, CAPD, test* 👏)
  • @elmiko (stepping in as a reviewer for docs, CAPD, test* 👏)
  • @g-gaston (stepping in as a reviewer for CABPK and KCP 👏)

All of you, please add your lgtm

cc @CecileRobertMichon @sbueringer @enxebre @vincepri

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. labels Jan 25, 2023
@elmiko
Copy link
Contributor

elmiko commented Jan 25, 2023

thanks @fabriziopandini !

ykakarap
ykakarap approved these changes Jan 25, 2023
View reviewed changes
Copy link
Contributor

@ykakarap ykakarap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 25, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 30993e930629e327872323ad36b9aa5f25ad24e5

@stmcginnis
Copy link
Contributor

/lgtm

🎉

@enxebre
Copy link
Member

enxebre commented Jan 25, 2023

/lgtm

@sbueringer
Copy link
Member

Congrats and thx everyone!!

/lgtm

@jackfrancis
Copy link
Contributor

🙏 (in lieu of a "I am humbled" emoji)

@oscr
Copy link
Contributor

oscr commented Jan 25, 2023

/lgtm

Thank you to everyone for all the help and support 🙏

killianmuldoon
killianmuldoon reviewed Jan 25, 2023
View reviewed changes
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks everyone!

@CecileRobertMichon
Copy link
Contributor

/lgtm

Welcome everyone 🙌

@fabriziopandini
Copy link
Member Author

setting 1-week lazy consensus, in the meantime, we should hopefully also get @g-gaston to join the org

@vincepri
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Jan 27, 2023
@oscr
Copy link
Contributor

oscr commented Jan 27, 2023

/test pull-cluster-api-test-mink8s-main

@richardcase
Copy link
Member

Thanks @fabriziopandini

/lgtm

@g-gaston
Copy link
Contributor

g-gaston commented Feb 1, 2023

Thanks!
/lgtm

@chrischdi
Copy link
Member

/lgtm

@fabriziopandini
Copy link
Member Author

Yay!

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 1, 2023
@k8s-ci-robot k8s-ci-robot merged commit 8d8e18a into kubernetes-sigs:main Feb 1, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.4 milestone Feb 1, 2023
@killianmuldoon
Copy link
Contributor

/cherry-pick release-1.2

@k8s-infra-cherrypick-robot
Copy link

@killianmuldoon: #7996 failed to apply on top of branch "release-1.3":

Applying: update owner files
Using index info to reconstruct a base tree...
M	OWNERS_ALIASES
Falling back to patching base and 3-way merge...
Auto-merging OWNERS_ALIASES
CONFLICT (content): Merge conflict in OWNERS_ALIASES
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 update owner files
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-1.3
/cherry-pick release-1.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@killianmuldoon
Copy link
Contributor

/cherry-pick release-1.3

@k8s-infra-cherrypick-robot
Copy link

@killianmuldoon: #7996 failed to apply on top of branch "release-1.2":

Applying: update owner files
Using index info to reconstruct a base tree...
M	OWNERS_ALIASES
Falling back to patching base and 3-way merge...
Auto-merging OWNERS_ALIASES
CONFLICT (content): Merge conflict in OWNERS_ALIASES
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 update owner files
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-1.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-infra-cherrypick-robot
Copy link

@killianmuldoon: #7996 failed to apply on top of branch "release-1.3":

Applying: update owner files
Using index info to reconstruct a base tree...
M	OWNERS_ALIASES
Falling back to patching base and 3-way merge...
Auto-merging OWNERS_ALIASES
CONFLICT (content): Merge conflict in OWNERS_ALIASES
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 update owner files
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-1.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Feb 6, 2023
Merged
Merged
@killianmuldoon killianmuldoon mentioned this pull request Feb 20, 2023
Merged
@fabriziopandini fabriziopandini deleted the update-owners branch March 24, 2023 14:23
@chrischdi chrischdi mentioned this pull request Aug 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@killianmuldoon killianmuldoon killianmuldoon left review comments

@ykakarap ykakarap ykakarap approved these changes

@stmcginnis stmcginnis Awaiting requested review from stmcginnis

@vincepri vincepri Awaiting requested review from vincepri

Assignees

@richardcase richardcase

@enxebre enxebre

@oscr oscr

@vincepri vincepri

@stmcginnis stmcginnis

@sbueringer sbueringer

@g-gaston g-gaston

@CecileRobertMichon CecileRobertMichon

@ykakarap ykakarap

@killianmuldoon killianmuldoon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.