🌱 Improve tilt-prepare for testing providers outside of the CAPI repository #7968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b561da4 to
1ab74ed
Compare
sbueringer
reviewed
Jan 23, 2023
|
/lgtm |
|
LGTM label has been added. Git tree hash: 47c318f24defc659b7bcacfd5f339430d8b8c6b7
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR allows this to specify a new field version in tilt-provider.yaml|json file
When testing providers outside of the CAPI repository with tilt, it makes sense that providers have their own version set in the provider CR, instead of all having the version used by components on the main CAPI branch.
E.g When running E2E tests for the kubemark provider with tilt in kubernetes-sigs/cluster-api-provider-kubemark#69, it is required that tilt is deployed as version v0.4.99 to match the version is in the test config file.
While changing tilt-prepare I made some little refactor to make clear what struct/func are about the tilt-settings file in the CAPI repository and what is about the the tilt-provider file in providers' repositories, but the diff is not playing out well 😅