Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⚠️ Removing deprecated --list-images flag on init command #7838

Merged
merged 1 commit into from
Jan 4, 2023
Merged

⚠️ Removing deprecated --list-images flag on init command #7838

merged 1 commit into from
Jan 4, 2023

Conversation

knabben
Copy link
Member

@knabben knabben commented Jan 3, 2023

What this PR does / why we need it:
Removing the deprecated --list-images from init command

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Part of #7713

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 3, 2023
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 3, 2023
@knabben knabben changed the title Removing deprecated --list-images flag on init command 🌱 Removing deprecated --list-images flag on init command Jan 3, 2023
@knabben knabben mentioned this pull request Jan 3, 2023
Closed
8 tasks
@fabriziopandini fabriziopandini changed the title 🌱 Removing deprecated --list-images flag on init command ⚠️ Removing deprecated --list-images flag on init command Jan 3, 2023
@fabriziopandini
Copy link
Member

/retest

lgtm pending CI singal
could you kindly add one line for this change in https://main.cluster-api.sigs.k8s.io/developer/providers/v1.3-to-v1.4.html#removals (this is a doc provider look at when upgrading)

@knabben knabben force-pushed the remove-list-images branch from 97dac11 to 8a56549 Compare January 3, 2023 21:05
fabriziopandini
fabriziopandini reviewed Jan 4, 2023
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 4, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 4584bb173660c94d7b418b3a4c24794ce45e89be

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jan 4, 2023
@knabben knabben force-pushed the remove-list-images branch from 8a56549 to 913714d Compare January 4, 2023 13:04
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 4, 2023
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 4, 2023
@sbueringer
Copy link
Member

sbueringer commented Jan 4, 2023 •
edited
Loading

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 4, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 1ceb088ba1e1c072f18c6ee8ffdc4b7c40c63d51

@knabben
Copy link
Member Author

knabben commented Jan 4, 2023

/retest

@k8s-ci-robot k8s-ci-robot merged commit 192517b into kubernetes-sigs:main Jan 4, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.4 milestone Jan 4, 2023
@knabben knabben deleted the remove-list-images branch January 4, 2023 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

@sbueringer sbueringer Awaiting requested review from sbueringer

@fabriziopandini fabriziopandini Awaiting requested review from fabriziopandini

Assignees

@sbueringer sbueringer

@fabriziopandini fabriziopandini

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.
4 participants
@knabben @fabriziopandini @k8s-ci-robot @sbueringer