-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 go.mod: Update github.com/google/go-github to v48.2.0 #7830
Conversation
6948f22
to
1885603
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx!
one nit otherwise lgtm
I'm slightly confused why dependabot didn't open a PR for it
go.mod
Outdated
@@ -150,6 +149,8 @@ require ( | |||
sigs.k8s.io/structured-merge-diff/v4 v4.2.3 // indirect | |||
) | |||
|
|||
require github.com/google/go-github/v48 v48.2.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's please change the version directly inline in l.20
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dependabot does not update this version on the left side
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done, PTAL @sbueringer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah good point.
Signed-off-by: cpanato <ctadeu@gmail.com>
1885603
to
09b2e26
Compare
/assign @sbueringer |
/lgtm |
/retest |
LGTM label has been added. Git tree hash: febdd4b9f1740b699c03803e7c7568dc1d3970e3
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
🌱 go.mod: Update github.com/google/go-github to v48.2.0
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
/assign @fabriziopandini